Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 711763002: bindings: Transition from ArrayBuffer to DOMArrayBuffer, part 2 (2nd round) (Closed)

Created:
6 years, 1 month ago by Yuki
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tyoshino+watch_chromium.org, serviceworker-reviews, arv+blink, tzik, yhirano+watch_chromium.org, sof, eae+blinkwatch, nhiroki, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+fileapi, rwlbuis
Project:
blink
Visibility:
Public.

Description

bindings: Transition from ArrayBuffer to DOMArrayBuffer, part 2 (2nd round). Replaces ArrayBuffer with DOMArrayBuffer in core/ and modules/. This CL is retry of http://crrev.com/708983002 Fixes Windows (64-bit) build. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185022

Patch Set 1 #

Patch Set 2 : Fixes Win x64 build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -52 lines) Patch
M Source/bindings/core/v8/custom/V8FileReaderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBuffer.h View 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/Body.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/DOMWebSocket.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/websockets/DOMWebSocketTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.h View 5 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 5 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/WorkerWebSocketChannel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WorkerWebSocketChannel.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/web/WebSocketImpl.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL? Fixed Win x64 build.
6 years, 1 month ago (2014-11-10 06:32:22 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-10 07:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711763002/20001
6 years, 1 month ago (2014-11-10 07:06:41 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 07:08:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185022

Powered by Google App Engine
This is Rietveld 408576698