Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/bindings/core/v8/custom/V8FileReaderCustom.cpp

Issue 711763002: bindings: Transition from ArrayBuffer to DOMArrayBuffer, part 2 (2nd round) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixes Win x64 build. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/DOMArrayBuffer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 #include "bindings/core/v8/V8Binding.h" 35 #include "bindings/core/v8/V8Binding.h"
36 #include "core/dom/ExecutionContext.h" 36 #include "core/dom/ExecutionContext.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 void V8FileReader::resultAttributeGetterCustom(const v8::PropertyCallbackInfo<v8 ::Value>& info) 40 void V8FileReader::resultAttributeGetterCustom(const v8::PropertyCallbackInfo<v8 ::Value>& info)
41 { 41 {
42 v8::Handle<v8::Object> holder = info.Holder(); 42 v8::Handle<v8::Object> holder = info.Holder();
43 FileReader* impl = V8FileReader::toImpl(holder); 43 FileReader* impl = V8FileReader::toImpl(holder);
44 if (impl->readType() == FileReaderLoader::ReadAsArrayBuffer) { 44 if (impl->readType() == FileReaderLoader::ReadAsArrayBuffer) {
45 v8SetReturnValueFast(info, DOMArrayBuffer::create(impl->arrayBufferResul t()), impl); 45 v8SetReturnValueFast(info, impl->arrayBufferResult(), impl);
46 return; 46 return;
47 } 47 }
48 v8SetReturnValueStringOrNull(info, impl->stringResult(), info.GetIsolate()); 48 v8SetReturnValueStringOrNull(info, impl->stringResult(), info.GetIsolate());
49 } 49 }
50 50
51 } // namespace blink 51 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/DOMArrayBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698