Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: sky/engine/core/frame/FrameConsole.cpp

Issue 711513003: Make import failures log errors (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: moar lceanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/html/imports/HTMLImportLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameConsole.cpp
diff --git a/sky/engine/core/frame/FrameConsole.cpp b/sky/engine/core/frame/FrameConsole.cpp
index f619702a7c7e3c614787a7bf218af1f1ef0d92d8..ce351e577b35001b25df84b9bcba314c4e7a8ded 100644
--- a/sky/engine/core/frame/FrameConsole.cpp
+++ b/sky/engine/core/frame/FrameConsole.cpp
@@ -96,9 +96,6 @@ void FrameConsole::addMessage(PassRefPtr<ConsoleMessage> prpConsoleMessage)
messageStorage()->reportMessage(consoleMessage);
- if (consoleMessage->source() == CSSMessageSource || consoleMessage->source() == NetworkMessageSource)
eseidel 2014/11/06 23:08:52 Why did you need to remove this?
rafaelw 2014/11/06 23:10:45 Loggin to stddout happens the call below to .chrom
rafaelw 2014/11/06 23:14:11 Note: I didn't fully follow the path that Blink/De
- return;
-
RefPtr<ScriptCallStack> reportedCallStack = nullptr;
if (consoleMessage->source() != ConsoleAPIMessageSource) {
if (consoleMessage->callStack() && m_frame.chromeClient().shouldReportDetailedMessageForSource(messageURL))
« no previous file with comments | « no previous file | sky/engine/core/html/imports/HTMLImportLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698