Make import failures log errors

sky/engine/core/frame/FrameConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 78 matching lines @@
     if (consoleMessage->callStack() && consoleMessage->callStack()->size()) {
         lineNumber = consoleMessage->callStack()->at(0).lineNumber();
         messageURL = consoleMessage->callStack()->at(0).sourceURL();
     } else {
         lineNumber = consoleMessage->lineNumber();
         messageURL = consoleMessage->url();
     }
 
     messageStorage()->reportMessage(consoleMessage);
 
-    if (consoleMessage->source() == CSSMessageSource || consoleMessage->source() == NetworkMessageSource)

[eseidel, 2014/11/06 23:08:52]

Why did you need to remove this?

[rafaelw, 2014/11/06 23:10:45]

Loggin to stddout happens the call below to .chromeClient().addMessageToConsole.
I suspect that DevTools uses the messageStorage() above.

On 2014/11/06 23:08:52, eseidel wrote:

[rafaelw, 2014/11/06 23:14:11]

Note: I didn't fully follow the path that Blink/Devtools takes. In blink, import
failures do long to the console (as well as the network tab) despite this return
for CSS & Network types - which made me assure they were arriving their somehow
via the messageStorage.

-        return;
-
     RefPtr<ScriptCallStack> reportedCallStack = nullptr;
     if (consoleMessage->source() != ConsoleAPIMessageSource) {
         if (consoleMessage->callStack() && m_frame.chromeClient().shouldReportDetailedMessageForSource(messageURL))
             reportedCallStack = consoleMessage->callStack();
     } else {
         if (!m_frame.host() || (consoleMessage->scriptArguments() && consoleMessage->scriptArguments()->argumentCount() == 0))
             return;
 
         if (!allClientReportingMessageTypes().contains(consoleMessage->type()))
             return;
@@ skipping 60 matching lines @@
 {
     messageStorage()->clear();
 }
 
 void FrameConsole::trace(Visitor* visitor)
 {
     visitor->trace(m_consoleMessageStorage);
 }
 
 } // namespace blink