Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 711483003: Deduplicate part of RenderLayerScrollableArea/ScrollableArea. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Deduplicate part of RenderLayerScrollableArea/ScrollableArea. ScrollableArea only has one subclass now. Make all it's virtual methods be pure virtual and delete any methods that RenderLayerScrollableArea overrides. Eventually we should probably merge the two classes into one, but ScrollableArea is in platform and RenderLayerScrollableArea is in core/rendering, so it's non-trivial figuring out what the end result should look like. Hopefully it will become more clear as we delete more of the scrolling code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9e6a0c579e54009a29ccc1d3532f116c0a90992b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -73 lines) Patch
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 2 chunks +28 lines, -28 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 7 chunks +19 lines, -28 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-08 03:46:35 UTC) #2
ojan
6 years, 1 month ago (2014-11-08 04:06:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e6a0c579e54009a29ccc1d3532f116c0a90992b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698