Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Side by Side Diff: sky/engine/core/rendering/RenderLayerScrollableArea.h

Issue 711483003: Deduplicate part of RenderLayerScrollableArea/ScrollableArea. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 class RenderLayerScrollableArea final : public ScrollableArea { 55 class RenderLayerScrollableArea final : public ScrollableArea {
56 public: 56 public:
57 // FIXME: We should pass in the RenderBox but this opens a window 57 // FIXME: We should pass in the RenderBox but this opens a window
58 // for crashers during RenderLayer setup (see crbug.com/368062). 58 // for crashers during RenderLayer setup (see crbug.com/368062).
59 RenderLayerScrollableArea(RenderLayer&); 59 RenderLayerScrollableArea(RenderLayer&);
60 virtual ~RenderLayerScrollableArea(); 60 virtual ~RenderLayerScrollableArea();
61 61
62 bool hasHorizontalScrollbar() const { return horizontalScrollbar(); } 62 bool hasHorizontalScrollbar() const { return horizontalScrollbar(); }
63 bool hasVerticalScrollbar() const { return verticalScrollbar(); } 63 bool hasVerticalScrollbar() const { return verticalScrollbar(); }
64 64
65 virtual Scrollbar* horizontalScrollbar() const override { return m_hBar.get( ); } 65 Scrollbar* horizontalScrollbar() const override { return m_hBar.get(); }
66 virtual Scrollbar* verticalScrollbar() const override { return m_vBar.get(); } 66 Scrollbar* verticalScrollbar() const override { return m_vBar.get(); }
67 67
68 virtual HostWindow* hostWindow() const override; 68 HostWindow* hostWindow() const override;
69 69
70 virtual GraphicsLayer* layerForScrolling() const override; 70 GraphicsLayer* layerForScrolling() const override;
71 virtual GraphicsLayer* layerForHorizontalScrollbar() const override; 71 GraphicsLayer* layerForHorizontalScrollbar() const override;
72 virtual GraphicsLayer* layerForVerticalScrollbar() const override; 72 GraphicsLayer* layerForVerticalScrollbar() const override;
73 virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&) override; 73 void invalidateScrollbarRect(Scrollbar*, const IntRect&) override;
74 virtual bool isActive() const override; 74 bool isActive() const override;
75 IntRect scrollCornerRect() const; 75 IntRect scrollCornerRect() const;
76 virtual IntRect convertFromScrollbarToContainingView(const Scrollbar*, const IntRect&) const override; 76 IntRect convertFromScrollbarToContainingView(const Scrollbar*, const IntRect &) const override;
77 virtual IntRect convertFromContainingViewToScrollbar(const Scrollbar*, const IntRect&) const override; 77 IntRect convertFromContainingViewToScrollbar(const Scrollbar*, const IntRect &) const override;
78 virtual IntPoint convertFromScrollbarToContainingView(const Scrollbar*, cons t IntPoint&) const override; 78 IntPoint convertFromScrollbarToContainingView(const Scrollbar*, const IntPoi nt&) const override;
79 virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar*, cons t IntPoint&) const override; 79 IntPoint convertFromContainingViewToScrollbar(const Scrollbar*, const IntPoi nt&) const override;
80 virtual int scrollSize(ScrollbarOrientation) const override; 80 int scrollSize(ScrollbarOrientation) const override;
81 virtual void setScrollOffset(const IntPoint&) override; 81 void setScrollOffset(const IntPoint&) override;
82 virtual IntPoint scrollPosition() const override; 82 IntPoint scrollPosition() const override;
83 virtual IntPoint minimumScrollPosition() const override; 83 IntPoint minimumScrollPosition() const override;
84 virtual IntPoint maximumScrollPosition() const override; 84 IntPoint maximumScrollPosition() const override;
85 virtual IntRect visibleContentRect(IncludeScrollbarsInRect) const override; 85 IntRect visibleContentRect(IncludeScrollbarsInRect) const;
86 virtual int visibleHeight() const override; 86 int visibleHeight() const;
87 virtual int visibleWidth() const override; 87 int visibleWidth() const;
88 virtual IntSize contentsSize() const override; 88 IntSize contentsSize() const override;
89 virtual IntSize overhangAmount() const override; 89 IntSize overhangAmount() const;
90 virtual IntPoint lastKnownMousePosition() const override; 90 IntPoint lastKnownMousePosition() const;
91 virtual IntRect scrollableAreaBoundingBox() const override; 91 IntRect scrollableAreaBoundingBox() const;
92 virtual bool userInputScrollable(ScrollbarOrientation) const override; 92 bool userInputScrollable(ScrollbarOrientation) const override;
93 virtual bool shouldPlaceVerticalScrollbarOnLeft() const override; 93 bool shouldPlaceVerticalScrollbarOnLeft() const override;
94 virtual int pageStep(ScrollbarOrientation) const override; 94 int pageStep(ScrollbarOrientation) const override;
95 95
96 int scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin().x (); } 96 int scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin().x (); }
97 int scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin(). y(); } 97 int scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin(). y(); }
98 98
99 IntSize scrollOffset() const { return m_scrollOffset; } 99 IntSize scrollOffset() const { return m_scrollOffset; }
100 100
101 // FIXME: We shouldn't allow access to m_overflowRect outside this class. 101 // FIXME: We shouldn't allow access to m_overflowRect outside this class.
102 LayoutRect overflowRect() const { return m_overflowRect; } 102 LayoutRect overflowRect() const { return m_overflowRect; }
103 103
104 void scrollToOffset(const IntSize& scrollOffset, ScrollOffsetClamping = Scro llOffsetUnclamped); 104 void scrollToOffset(const IntSize& scrollOffset, ScrollOffsetClamping = Scro llOffsetUnclamped);
105 void scrollToXOffset(int x, ScrollOffsetClamping clamp = ScrollOffsetUnclamp ed) { scrollToOffset(IntSize(x, scrollYOffset()), clamp); } 105 void scrollToXOffset(int x, ScrollOffsetClamping clamp = ScrollOffsetUnclamp ed) { scrollToOffset(IntSize(x, scrollYOffset()), clamp); }
106 void scrollToYOffset(int y, ScrollOffsetClamping clamp = ScrollOffsetUnclamp ed) { scrollToOffset(IntSize(scrollXOffset(), y), clamp); } 106 void scrollToYOffset(int y, ScrollOffsetClamping clamp = ScrollOffsetUnclamp ed) { scrollToOffset(IntSize(scrollXOffset(), y), clamp); }
107 107
108 void updateAfterLayout(); 108 void updateAfterLayout();
109 void updateAfterStyleChange(const RenderStyle*); 109 void updateAfterStyleChange(const RenderStyle*);
110 void updateAfterOverflowRecalc(); 110 void updateAfterOverflowRecalc();
111 111
112 virtual bool updateAfterCompositingChange() override; 112 bool updateAfterCompositingChange() override;
113 113
114 bool hasScrollbar() const { return m_hBar || m_vBar; } 114 bool hasScrollbar() const { return m_hBar || m_vBar; }
115 115
116 LayoutUnit scrollWidth() const; 116 LayoutUnit scrollWidth() const;
117 LayoutUnit scrollHeight() const; 117 LayoutUnit scrollHeight() const;
118 int pixelSnappedScrollWidth() const; 118 int pixelSnappedScrollWidth() const;
119 int pixelSnappedScrollHeight() const; 119 int pixelSnappedScrollHeight() const;
120 120
121 IntSize adjustedScrollOffset() const { return IntSize(scrollXOffset(), scrol lYOffset()); } 121 IntSize adjustedScrollOffset() const { return IntSize(scrollXOffset(), scrol lYOffset()); }
122 122
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 IntPoint m_cachedOverlayScrollbarOffset; 194 IntPoint m_cachedOverlayScrollbarOffset;
195 195
196 // For areas with overflow, we have a pair of scrollbars. 196 // For areas with overflow, we have a pair of scrollbars.
197 RefPtr<Scrollbar> m_hBar; 197 RefPtr<Scrollbar> m_hBar;
198 RefPtr<Scrollbar> m_vBar; 198 RefPtr<Scrollbar> m_vBar;
199 }; 199 };
200 200
201 } // namespace blink 201 } // namespace blink
202 202
203 #endif // RenderLayerScrollableArea_h 203 #endif // RenderLayerScrollableArea_h
OLDNEW
« no previous file with comments | « no previous file | sky/engine/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698