Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 711423002: DevTools: better visual feedback for hovered objects is Layers3DView (Closed)

Created:
6 years, 1 month ago by caseq
Modified:
6 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: better visual feedback for hovered objects is Layers3DView - rename WebInspector.Layers3DView.ActiveObject to ...Selection; - introduce proper constructors and isEqual methods for Selection; - generalize hover/selection handling logic for different objects; - make hovered (but not selected) object bluish Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185203

Patch Set 1 : #

Total comments: 1

Patch Set 2 : addressed review comments, fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -149 lines) Patch
M LayoutTests/inspector/layers/layers-3d-view-hit-testing.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/layers/LayersPanel.js View 3 chunks +17 lines, -17 lines 0 comments Download
M Source/devtools/front_end/timeline/LayerDetailsView.js View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/LayerTreeOutline.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 1 20 chunks +148 lines, -107 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineLayersView.js View 3 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
6 years, 1 month ago (2014-11-11 15:31:54 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/711423002/diff/20001/Source/devtools/front_end/timeline/Layers3DView.js File Source/devtools/front_end/timeline/Layers3DView.js (right): https://codereview.chromium.org/711423002/diff/20001/Source/devtools/front_end/timeline/Layers3DView.js#newcode432 Source/devtools/front_end/timeline/Layers3DView.js:432: if (isSelected) {}
6 years, 1 month ago (2014-11-11 17:25:48 UTC) #4
caseq
On 2014/11/11 17:25:48, pfeldman wrote: > lgtm > > https://codereview.chromium.org/711423002/diff/20001/Source/devtools/front_end/timeline/Layers3DView.js > File Source/devtools/front_end/timeline/Layers3DView.js (right): > ...
6 years, 1 month ago (2014-11-12 10:11:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711423002/40001
6 years, 1 month ago (2014-11-12 10:11:53 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 12:13:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as 185203

Powered by Google App Engine
This is Rietveld 408576698