Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: Source/devtools/front_end/timeline/TimelineLayersView.js

Issue 711423002: DevTools: better visual feedback for hovered objects is Layers3DView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed review comments, fixed test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineLayersView.js
diff --git a/Source/devtools/front_end/timeline/TimelineLayersView.js b/Source/devtools/front_end/timeline/TimelineLayersView.js
index 5bc1160afd4d05f5846b9cb8c1d21bb2ba1c1d9b..cbd83eace64823243ab3efdddc444ae322bc1dfa 100644
--- a/Source/devtools/front_end/timeline/TimelineLayersView.js
+++ b/Source/devtools/front_end/timeline/TimelineLayersView.js
@@ -146,32 +146,32 @@ WebInspector.TimelineLayersView.prototype = {
},
/**
- * @param {?WebInspector.Layers3DView.ActiveObject} activeObject
+ * @param {?WebInspector.Layers3DView.Selection} selection
*/
- _selectObject: function(activeObject)
+ _selectObject: function(selection)
{
- var layer = activeObject && activeObject.layer;
- if (this._currentlySelectedLayer === activeObject)
+ var layer = selection && selection.layer;
+ if (this._currentlySelectedLayer === selection)
return;
- this._currentlySelectedLayer = activeObject;
+ this._currentlySelectedLayer = selection;
this._toggleNodeHighlight(layer ? layer.nodeForSelfOrAncestor() : null);
this._layerTreeOutline.selectLayer(layer);
- this._layers3DView.selectObject(activeObject);
- this._layerDetailsView.setObject(activeObject);
+ this._layers3DView.selectObject(selection);
+ this._layerDetailsView.setObject(selection);
},
/**
- * @param {?WebInspector.Layers3DView.ActiveObject} activeObject
+ * @param {?WebInspector.Layers3DView.Selection} selection
*/
- _hoverObject: function(activeObject)
+ _hoverObject: function(selection)
{
- var layer = activeObject && activeObject.layer;
- if (this._currentlyHoveredLayer === activeObject)
+ var layer = selection && selection.layer;
+ if (this._currentlyHoveredLayer === selection)
return;
- this._currentlyHoveredLayer = activeObject;
+ this._currentlyHoveredLayer = selection;
this._toggleNodeHighlight(layer ? layer.nodeForSelfOrAncestor() : null);
this._layerTreeOutline.hoverLayer(layer);
- this._layers3DView.hoverObject(activeObject);
+ this._layers3DView.hoverObject(selection);
},
/**
@@ -193,8 +193,8 @@ WebInspector.TimelineLayersView.prototype = {
*/
_onObjectSelected: function(event)
{
- var activeObject = /** @type {!WebInspector.Layers3DView.ActiveObject} */ (event.data);
- this._selectObject(activeObject);
+ var selection = /** @type {!WebInspector.Layers3DView.Selection} */ (event.data);
+ this._selectObject(selection);
},
/**
@@ -202,8 +202,8 @@ WebInspector.TimelineLayersView.prototype = {
*/
_onObjectHovered: function(event)
{
- var activeObject = /** @type {!WebInspector.Layers3DView.ActiveObject} */ (event.data);
- this._hoverObject(activeObject);
+ var selection = /** @type {!WebInspector.Layers3DView.Selection} */ (event.data);
+ this._hoverObject(selection);
},
_disposeTiles: function()
« no previous file with comments | « Source/devtools/front_end/timeline/Layers3DView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698