Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 711323002: Oilpan: Don't destruct HRTFDatabaseLoader::m_thread during a sweeping phase (Closed)

Created:
6 years, 1 month ago by haraken
Modified:
6 years, 1 month ago
Reviewers:
oilpan-reviews, sof1, sof, tkent
CC:
blink-reviews, Raymond Toy
Project:
blink
Visibility:
Public.

Description

Oilpan: Don't destruct HRTFDatabaseLoader::m_thread during a sweeping phase It is not allowed to destruct HRTFDatabaseLoader::m_thread during a sweeping phase because WebThreadSupportingGC's destructor enters a safe point scope. This CL avoids the situation by explicitly joining with the loader thread in AudioContext::uninitialize(). In order to make sure that the loader thread finishes touching m_thread, this CL posts a clean-up task and wait for its completion before calling m_thread.clear(). BUG=432041 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185177

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M Source/modules/webaudio/AudioContext.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioListener.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.h View 1 2 3 4 3 chunks +6 lines, -3 lines 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.cpp View 1 2 4 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
6 years, 1 month ago (2014-11-11 11:18:42 UTC) #2
sof
Thanks for jumping in and fixing this right away. lgtm, but would be good to ...
6 years, 1 month ago (2014-11-11 12:05:30 UTC) #4
haraken
tkent-san: Can you take another look? https://codereview.chromium.org/711323002/diff/40001/Source/platform/audio/HRTFDatabaseLoader.h File Source/platform/audio/HRTFDatabaseLoader.h (right): https://codereview.chromium.org/711323002/diff/40001/Source/platform/audio/HRTFDatabaseLoader.h#newcode68 Source/platform/audio/HRTFDatabaseLoader.h:68: void cleanupTask(TaskSynchronizer*); On ...
6 years, 1 month ago (2014-11-11 14:25:41 UTC) #6
tkent
lgtm
6 years, 1 month ago (2014-11-12 03:26:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711323002/100001
6 years, 1 month ago (2014-11-12 04:22:29 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 05:03:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 185177

Powered by Google App Engine
This is Rietveld 408576698