Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: Source/platform/audio/HRTFDatabaseLoader.h

Issue 711323002: Oilpan: Don't destruct HRTFDatabaseLoader::m_thread during a sweeping phase (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioListener.cpp ('k') | Source/platform/audio/HRTFDatabaseLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/audio/HRTFDatabaseLoader.h
diff --git a/Source/platform/audio/HRTFDatabaseLoader.h b/Source/platform/audio/HRTFDatabaseLoader.h
index 74408b2cf76efdf53acb8ca1eae4dffafdcbe8b1..fcdd1a6d1336e4769793cfbdcfa56988dcdd92d2 100644
--- a/Source/platform/audio/HRTFDatabaseLoader.h
+++ b/Source/platform/audio/HRTFDatabaseLoader.h
@@ -37,6 +37,8 @@
namespace blink {
+class TaskSynchronizer;
+
// HRTFDatabaseLoader will asynchronously load the default HRTFDatabase in a new thread.
class PLATFORM_EXPORT HRTFDatabaseLoader final : public GarbageCollectedFinalized<HRTFDatabaseLoader> {
@@ -60,9 +62,6 @@ public:
float databaseSampleRate() const { return m_databaseSampleRate; }
- // Called in asynchronous loading thread.
- void load();
-
void trace(Visitor*) { }
private:
@@ -73,6 +72,10 @@ private:
// This must be called from the main thread.
void loadAsynchronously();
+ // Called in asynchronous loading thread.
+ void loadTask();
+ void cleanupTask(TaskSynchronizer*);
+
// Holding a m_lock is required when accessing m_hrtfDatabase since we access it from multiple threads.
Mutex m_lock;
OwnPtr<HRTFDatabase> m_hrtfDatabase;
« no previous file with comments | « Source/modules/webaudio/AudioListener.cpp ('k') | Source/platform/audio/HRTFDatabaseLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698