Issue 7112030: Make backing store for incremental marking deque non-static.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7112030: Make backing store for incremental marking deque non-static. (Closed)

Created:
9 years, 6 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Make backing store for incremental marking deque non-static. Make scavenging visitors dispatch table non-static. BUG=v8:1411 Committed: http://code.google.com/p/v8/source/detail?r=8179

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+198 lines, -138 lines)			Patch
M	src/heap.h	View	5 chunks	+12 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	9 chunks	+21 lines, -27 lines	0 comments	Download
M	src/incremental-marking.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/incremental-marking.cc	View	6 chunks	+19 lines, -13 lines	1 comment	Download
M	src/mark-compact.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-visiting.h	View	2 chunks	+1 line, -95 lines	0 comments	Download
A	src/objects-visiting-inl.h	View	1 chunk	+136 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 6 months ago (2011-06-06 10:27:39 UTC) #2

LGTM

http://codereview.chromium.org/7112030/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/7112030/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:378: } else if (obj->map() != filler_map) {
It would be nice with a comment as to how these grey single-word fillers got to
be here.

Expand Messages | Collapse Messages