Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 710703002: Revert "Teach PRESUBMIT.py how to run gn check for most of the mojo repo" (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Revert "Teach PRESUBMIT.py how to run gn check for most of the mojo repo" This reverts commit dea154634ceba9cb855619259aa643857b9995ac. Causing link errors due to multiple definitions of GL thunk symbols. TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b8afdda71686b7904049924f6e9b434e78df6151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -109 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/application/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/application_manager/BUILD.gn View 1 chunk +3 lines, -6 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/apps/js/bindings/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/aura/BUILD.gn View 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/edk/js/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +6 lines, -10 lines 0 comments Download
M mojo/shell/BUILD.gn View 7 chunks +7 lines, -29 lines 0 comments Download
M mojo/spy/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/tools/package_manager/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/views/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: obj/mojo/public/platform/native/gles2_thunks.gles2_impl_chromium_sync_point_thunks.o: multiple definition of 'MojoGLES2glInsertSyncPointCHROMIUM' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: obj/mojo/gles2/mojo_gles2_impl.gles2_impl.o: previous definition here
6 years, 1 month ago (2014-11-07 18:04:36 UTC) #2
eseidel
6 years, 1 month ago (2014-11-07 18:05:04 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b8afdda71686b7904049924f6e9b434e78df6151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698