Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: PRESUBMIT.py

Issue 710703002: Revert "Teach PRESUBMIT.py how to run gn check for most of the mojo repo" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/application/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3c8babe97b7cfe731d40f19b32502222a9b15241..79de95ffa95303e779f89fe9b4100687620f6f05 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -444,20 +444,7 @@ def _CheckGNCheck(input_api, output_api):
# TODO(eseidel): Currently only these are known to pass,
# once everything passes we can just call 'gn check' once without a filter!
KNOWN_PASSING = [
- '//build/*',
- '//mojo/application/*',
- '//mojo/apps/*',
- '//mojo/aura/*',
- '//mojo/cc/*',
- '//mojo/common/*',
'//mojo/public/*',
- '//mojo/spy/*',
- '//mojo/tools/*',
- '//mojo/views/*',
- '//skia/*',
- '//testing/*',
- '//tools/*',
- '//ui/*',
]
if input_api.platform != 'win32':
KNOWN_PASSING += [
« no previous file with comments | « no previous file | mojo/application/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698