Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 710613002: Arm64: Remove forced csp alignment to 16 byte values for Nvidia chips. (Closed)

Created:
6 years, 1 month ago by rmcilroy
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Arm64: Remove forced csp alignment to 16 byte values for Nvidia chips. Remove the forced alignment of csp to 16 byte values on Nvidia chips. Benchmarks on current devices show that this is no longer required. R=rodolph.perfetta@arm.com, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25225

Patch Set 1 : #

Patch Set 2 : Add back SyncSystemStackPointer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -50 lines) Patch
M src/arm64/assembler-arm64.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 2 chunks +2 lines, -13 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmcilroy
PTAL, thanks.
6 years, 1 month ago (2014-11-07 07:38:18 UTC) #3
ulan
lgtm, thank you.
6 years, 1 month ago (2014-11-07 08:15:07 UTC) #4
Rodolph Perfetta (ARM)
LGTM with one nit, could you leave the SyncSystemStackPointer method even if it is a ...
6 years, 1 month ago (2014-11-07 08:36:10 UTC) #5
rmcilroy
On 2014/11/07 08:36:10, Rodolph Perfetta (ARM) wrote: > LGTM with one nit, could you leave ...
6 years, 1 month ago (2014-11-07 19:00:30 UTC) #6
rmcilroy
6 years, 1 month ago (2014-11-07 23:34:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 25225 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698