Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2485)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return nullptr for CreateInfoBar() in test_autofill_client.cc. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index c008944acd3757ab1d46bef5e3e951b49b2129ad..6523df751387458d88c7b7a656f1d119eea0d19b 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -6,7 +6,6 @@
#include "base/logging.h"
#include "base/prefs/pref_service.h"
-#include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
#include "chrome/browser/autofill/personal_data_manager_factory.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
@@ -23,7 +22,9 @@
#include "chrome/common/url_constants.h"
#include "components/autofill/content/browser/content_autofill_driver.h"
#include "components/autofill/content/common/autofill_messages.h"
+#include "components/autofill/core/browser/autofill_cc_infobar_delegate.h"
#include "components/autofill/core/common/autofill_pref_names.h"
+#include "components/infobars/core/infobar.h"
#include "content/public/browser/render_view_host.h"
#include "ui/gfx/rect.h"
@@ -106,12 +107,12 @@ void ChromeAutofillClient::ShowAutofillSettings() {
}
void ChromeAutofillClient::ConfirmSaveCreditCard(
+ AutofillManager* autofill_manager,
const AutofillMetrics& metric_logger,
const base::Closure& save_card_callback) {
- InfoBarService* infobar_service =
- InfoBarService::FromWebContents(web_contents_);
AutofillCCInfoBarDelegate::Create(
- infobar_service, &metric_logger, save_card_callback);
+ InfoBarService::FromWebContents(web_contents_), autofill_manager,
+ &metric_logger, save_card_callback);
}
Ilya Sherman 2014/12/03 20:00:20 Does this entire method still need to be defined o
Pritam Nikam 2014/12/04 15:37:30 Done. But I think, I didn't get this completely.
bool ChromeAutofillClient::HasCreditCardScanFeature() {
@@ -222,4 +223,9 @@ void ChromeAutofillClient::DidFillOrPreviewField(
#endif // defined(OS_ANDROID)
}
+scoped_ptr<infobars::InfoBar> ChromeAutofillClient::CreateInfoBar(
+ scoped_ptr<ConfirmInfoBarDelegate> delegate) {
+ return ConfirmInfoBarDelegate::CreateInfoBar(delegate.Pass());
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698