components/autofill.gypi - Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill.gypi

Issue 710453002: [Autofill] Componentize AutofillCCInfoBarDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return nullptr for CreateInfoBar() in test_autofill_client.cc. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/chrome_autofill_client.cc ('K') | « chrome/chrome_browser.gypi ('k') | components/autofill/content/browser/content_autofill_driver.h » ('j') | components/autofill/core/browser/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill.gypi

diff --git a/components/autofill.gypi b/components/autofill.gypi

index c67abc5835f0571b47d8abeabe7968b6c94b2133..0b000ca5439c6702730caa385cda657910c2a9a2 100644

--- a/components/autofill.gypi

+++ b/components/autofill.gypi

@@ -97,6 +97,7 @@

'autofill_regexes',

'components_resources.gyp:components_resources',

'components_strings.gyp:components_strings',

+ 'infobars_core',

'keyed_service_core',

'os_crypt',

'pref_registry',

@@ -112,6 +113,8 @@

'autofill/core/browser/autocomplete_history_manager.cc',

'autofill/core/browser/autocomplete_history_manager.h',

'autofill/core/browser/autofill-inl.h',

+ 'autofill/core/browser/autofill_cc_infobar_delegate.cc',

+ 'autofill/core/browser/autofill_cc_infobar_delegate.h',

'autofill/core/browser/autofill_country.cc',

'autofill/core/browser/autofill_country.h',

'autofill/core/browser/autofill_data_model.cc',

@@ -354,6 +357,7 @@

'autofill_regexes',

'components_resources.gyp:components_resources',

'components_strings.gyp:components_strings',

+ 'infobars_core',

Ilya Sherman 2014/12/03 20:00:20 Why is this needed?

Pritam Nikam 2014/12/04 15:37:30 Done. Over-boarded! removed.

'os_crypt',

'user_prefs',

'webdata_common',

@@ -421,6 +425,7 @@

'autofill_content_common',

'autofill_core_common',

'components_strings.gyp:components_strings',

+ 'infobars_core',

Ilya Sherman 2014/12/03 20:00:20 Why does the renderer need a dependency on infobar

Pritam Nikam 2014/12/04 15:37:30 Done. Ditto!

'sources': [

'autofill/content/renderer/autofill_agent.cc',