src/arm/full-codegen-arm.cc - Issue 7104107: Incremental mode now works for x64. The only difference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 7104107: Incremental mode now works for x64. The only difference (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/full-codegen-arm.cc

===================================================================

--- src/arm/full-codegen-arm.cc (revision 8221)

+++ src/arm/full-codegen-arm.cc (working copy)

@@ -3275,6 +3275,8 @@

// Possible optimization: do a check that both values are Smis

// (or them and test against Smi mask.)

+ // Since we are swapping two objects, the incremental marker is not disturbed,

+ // so we don't call the stub that handles this.

Lasse Reichstein 2011/06/10 13:55:44 More explanation (e.g. that the incremental marker

Erik Corry 2011/06/10 21:57:29 Done.

__ RememberedSetHelper(

index1, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd);

__ RememberedSetHelper(