Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2011 the V8 project authors. All rights reserved. | 1 // Copyright 2011 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 3257 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3268 | 3268 |
| 3269 Label no_remembered_set; | 3269 Label no_remembered_set; |
| 3270 __ CheckPageFlag(elements, | 3270 __ CheckPageFlag(elements, |
| 3271 scratch1, | 3271 scratch1, |
| 3272 MemoryChunk::SCAN_ON_SCAVENGE, | 3272 MemoryChunk::SCAN_ON_SCAVENGE, |
| 3273 ne, | 3273 ne, |
| 3274 &no_remembered_set); | 3274 &no_remembered_set); |
| 3275 // Possible optimization: do a check that both values are Smis | 3275 // Possible optimization: do a check that both values are Smis |
| 3276 // (or them and test against Smi mask.) | 3276 // (or them and test against Smi mask.) |
| 3277 | 3277 |
| 3278 // Since we are swapping two objects, the incremental marker is not disturbed, | |
| 3279 // so we don't call the stub that handles this. | |
|
Lasse Reichstein
2011/06/10 13:55:44
More explanation (e.g. that the incremental marker
Erik Corry
2011/06/10 21:57:29
Done.
| |
| 3278 __ RememberedSetHelper( | 3280 __ RememberedSetHelper( |
| 3279 index1, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); | 3281 index1, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); |
| 3280 __ RememberedSetHelper( | 3282 __ RememberedSetHelper( |
| 3281 index2, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); | 3283 index2, scratch2, kDontSaveFPRegs, MacroAssembler::kFallThroughAtEnd); |
| 3282 | 3284 |
| 3283 __ bind(&no_remembered_set); | 3285 __ bind(&no_remembered_set); |
| 3284 // We are done. Drop elements from the stack, and return undefined. | 3286 // We are done. Drop elements from the stack, and return undefined. |
| 3285 __ Drop(3); | 3287 __ Drop(3); |
| 3286 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex); | 3288 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex); |
| 3287 __ jmp(&done); | 3289 __ jmp(&done); |
| (...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 4386 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. | 4388 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. |
| 4387 __ add(pc, r1, Operand(masm_->CodeObject())); | 4389 __ add(pc, r1, Operand(masm_->CodeObject())); |
| 4388 } | 4390 } |
| 4389 | 4391 |
| 4390 | 4392 |
| 4391 #undef __ | 4393 #undef __ |
| 4392 | 4394 |
| 4393 } } // namespace v8::internal | 4395 } } // namespace v8::internal |
| 4394 | 4396 |
| 4395 #endif // V8_TARGET_ARCH_ARM | 4397 #endif // V8_TARGET_ARCH_ARM |
| OLD | NEW |