Remove some null checks in MediaValuesCached that are now redundant.

Remove some null checks in MediaValuesCached that are now redundant.

Scripting is forbidden during Document::detach() now, so these checks
are no longer needed.

BUG=367210, 371084
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185061

[dcheng, 2014-11-10 18:27:28]

dcheng@chromium.org changed reviewers:
+ yoav@yoav.ws

[Yoav Weiss, 2014-11-10 19:28:47]

LGTM, with a comment.

https://codereview.chromium.org/710153002/diff/1/Source/core/css/MediaValuesC...
File Source/core/css/MediaValuesCached.cpp (left):

https://codereview.chromium.org/710153002/diff/1/Source/core/css/MediaValuesC...
Source/core/css/MediaValuesCached.cpp:35: if (!frame || !frame->view() ||
!frame->document() || !frame->document()->renderView())
Can we add an assert here that makes sure that frame->document() and
frame->document()->renderView() are not null? That'd both document that
assumption, and make sure regressions would be easy to spot.

[dcheng, 2014-11-10 19:41:58]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2014-11-10 19:41:58]

https://codereview.chromium.org/710153002/diff/1/Source/core/css/MediaValuesC...
File Source/core/css/MediaValuesCached.cpp (left):

https://codereview.chromium.org/710153002/diff/1/Source/core/css/MediaValuesC...
Source/core/css/MediaValuesCached.cpp:35: if (!frame || !frame->view() ||
!frame->document() || !frame->document()->renderView())
On 2014/11/10 19:28:47, Yoav Weiss wrote:
> Can we add an assert here that makes sure that frame->document() and
> frame->document()->renderView() are not null? That'd both document that
> assumption, and make sure regressions would be easy to spot.

Done.

[commit-bot: I haz the power, 2014-11-10 19:42:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/710153002/20001

[commit-bot: I haz the power, 2014-11-10 20:55:39]

Committed patchset #2 (id:20001) as 185061