Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: Source/core/css/MediaValuesCached.cpp

Issue 710153002: Remove some null checks in MediaValuesCached that are now redundant. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Asserts Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaValuesCached.cpp
diff --git a/Source/core/css/MediaValuesCached.cpp b/Source/core/css/MediaValuesCached.cpp
index 8f0816a52bf22e4d83a0d64e88a6324a5d014f78..0e0b65797bbe3259f1a4c41a0413ccff28e71576 100644
--- a/Source/core/css/MediaValuesCached.cpp
+++ b/Source/core/css/MediaValuesCached.cpp
@@ -31,9 +31,9 @@ PassRefPtr<MediaValues> MediaValuesCached::create(LocalFrame* frame)
{
// FIXME - Added an assert here so we can better understand when a frame is present without its view().
ASSERT(!frame || frame->view());
- // FIXME - Because of crbug.com/371084, document()->renderView() may be null here.
- if (!frame || !frame->view() || !frame->document() || !frame->document()->renderView())
+ if (!frame || !frame->view())
return adoptRef(new MediaValuesCached());
+ ASSERT(frame->document() && frame->document()->renderView());
return adoptRef(new MediaValuesCached(frame));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698