Store attachment crc in AttachmentStore

sync/internal_api/public/attachments/attachment_util.h

Index: sync/internal_api/public/attachments/attachment_util.h
diff --git a/sync/internal_api/public/attachments/attachment_util.h b/sync/internal_api/public/attachments/attachment_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..62712c97b45e8060d8a7d470615c391623b0d6a2
--- /dev/null
+++ b/sync/internal_api/public/attachments/attachment_util.h
@@ -0,0 +1,23 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_
+#define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_
+
+#include "base/memory/ref_counted.h"
+
+namespace base {
+class RefCountedMemory;
+}
+
+namespace syncer {
+
+// Return the crc32c of the memory described by |data|.
+//
+// Potentially expensive.
+uint32_t ComputeCrc32c(const scoped_refptr<base::RefCountedMemory>& data);

[maniscalco, 2014/11/11 00:44:54]

WDYT about putting this on Attachment (public, static) ?  IMO it seems like a
good fit.

[pavely, 2014/11/11 22:27:15]

I'd love to but seems like I can't include third_party from sync/api. The whole
reason for creating this file is to workaround that constraint.

[maniscalco, 2014/11/11 23:05:32]

Ah, right, sync/api/attachments inherits sync/api's DEPS which prohibits
third_party stuff.

Another option is to add a DEPS to sync/api/attachments and allow the inclusion
of leveldb.  I'm OK with either one.

If we think we may run into this with other stuff that fits in
sync/api/attachments, we should probably go the updated DEPS route.  If we think
this is the only one, the util class seems OK.

+
+}  // namespace syncer
+
+#endif  // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_