sync/internal_api/public/attachments/attachment_util.h - Issue 710073003: Store attachment crc in AttachmentStore

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/internal_api/public/attachments/attachment_util.h

Issue 710073003: Store attachment crc in AttachmentStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_

	6 #define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_

	7

	8 #include "base/memory/ref_counted.h"

	9

	10 namespace base {

	11 class RefCountedMemory;

	12 }

	13

	14 namespace syncer {

	15

	16 // Return the crc32c of the memory described by \|data\|.

	17 //

	18 // Potentially expensive.

	19 uint32_t ComputeCrc32c(const scoped_refptr<base::RefCountedMemory>& data);
	maniscalco 2014/11/11 00:44:54 WDYT about putting this on Attachment (public, sta WDYT about putting this on Attachment (public, static) ? IMO it seems like a good fit. pavely 2014/11/11 22:27:15 I'd love to but seems like I can't include third_p Show quoted text On 2014/11/11 00:44:54, maniscalco wrote: > WDYT about putting this on Attachment (public, static) ? IMO it seems like a > good fit. I'd love to but seems like I can't include third_party from sync/api. The whole reason for creating this file is to workaround that constraint. maniscalco 2014/11/11 23:05:32 Ah, right, sync/api/attachments inherits sync/api' Show quoted text On 2014/11/11 22:27:15, pavely wrote: > On 2014/11/11 00:44:54, maniscalco wrote: > > WDYT about putting this on Attachment (public, static) ? IMO it seems like a > > good fit. > > I'd love to but seems like I can't include third_party from sync/api. The whole > reason for creating this file is to workaround that constraint. Ah, right, sync/api/attachments inherits sync/api's DEPS which prohibits third_party stuff. Another option is to add a DEPS to sync/api/attachments and allow the inclusion of leveldb. I'm OK with either one. If we think we may run into this with other stuff that fits in sync/api/attachments, we should probably go the updated DEPS route. If we think this is the only one, the util class seems OK.
	20

	21 } // namespace syncer

	22

	23 #endif // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UTIL_H_

OLD	NEW