chrome/test/data/extensions/api_test/messaging/connect/manifest.json - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/messaging/connect/manifest.json

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/message_service.cc ('K') | « chrome/test/data/extensions/api_test/messaging/connect/frame.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('j') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/messaging/connect/manifest.json

diff --git a/chrome/test/data/extensions/api_test/messaging/connect/manifest.json b/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

index 0fa4c590a28963da7dada6499c6f4d8ff50b6d09..ed3187b55c02cccdb12368c8f1c291eb966eac4d 100644

--- a/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

+++ b/chrome/test/data/extensions/api_test/messaging/connect/manifest.json

@@ -12,6 +12,11 @@

{

"matches": ["http://*/*"],

"js": ["page.js"]

+ },

+ {

+ "all_frames": true,

+ "matches": ["http://*/*?frame_test"],

+ "js": ["frame.js"]

}

]

}