chrome/test/data/extensions/api_test/messaging/connect/manifest.json - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/messaging/connect/manifest.json

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/messaging/message_service.cc ('K') | « chrome/test/data/extensions/api_test/messaging/connect/frame.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('j') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "connect_external",	2 "name": "connect_external",

3 "version": "1.0",	3 "version": "1.0",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "description": "Tests connect from a content script.",	5 "description": "Tests connect from a content script.",

6 "permissions": ["tabs"],	6 "permissions": ["tabs"],

7 "background": {	7 "background": {

8 "persistent": false,	8 "persistent": false,

9 "scripts": ["test.js"]	9 "scripts": ["test.js"]

10 },	10 },

11 "content_scripts": [	11 "content_scripts": [

12 {	12 {

13 "matches": ["http:///"],	13 "matches": ["http:///"],

14 "js": ["page.js"]	14 "js": ["page.js"]

	15 },

	16 {

	17 "all_frames": true,

	18 "matches": ["http:///?frame_test"],

	19 "js": ["frame.js"]

15 }	20 }

16 ]	21 ]

17 }	22 }

OLD	NEW