Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709813004: Remove the deprecated function ExtensionService::extensions(). (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, arv+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, vsevik, chromoting-reviews_chromium.org, pvalenzuela+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, nhiroki, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, kalyank, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, yurys, tommycli, Greg Billock, wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the deprecated function ExtensionService::extensions(). This function has been deprecated in favor of ExtensionRegistry::enabled_extensions(). Some caller were immediately calling ExtensionSet::GetByID() and so these callers have been converted to ExtensionRegistry::GetExtensionById() instead. Cleaning up usage of this deprecated function removes a number of files which pull in ExtensionService that really only need to use ExtensionRegistry. BUG= Committed: https://crrev.com/a3acbc189be0d9d5d7f37f218d8d8c124273d917 Cr-Commit-Position: refs/heads/master@{#303742}

Patch Set 1 : #

Total comments: 20

Patch Set 2 : One more (hopefully last) OS X compile fix. #

Patch Set 3 : Addressed kalman@'s comments. #

Patch Set 4 : Fix Chrome OS compile failure. #

Total comments: 4

Patch Set 5 : Addressed thestig@'s comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+613 lines, -752 lines) Patch
M chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 16 chunks +109 lines, -138 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.cc View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 1 2 4 chunks +13 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper_unittest.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 2 15 chunks +70 lines, -85 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 1 2 9 chunks +33 lines, -29 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 10 chunks +20 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_functional_browsertest.cc View 1 2 5 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 2 4 chunks +14 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_view_host_factory.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 2 5 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 1 2 7 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/extensions/test_extension_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc View 1 2 4 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_test_util.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/location_bar/origin_chip_info.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/media_utils.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/identity_internals_ui.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 2 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 2 3 4 4 chunks +11 lines, -21 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.cc View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Reilly Grant (use Gerrit)
Kalman, please take a look at the ExtensionService change and updates in chrome/browser/extensions. With your ...
6 years, 1 month ago (2014-11-11 19:33:03 UTC) #4
not at google - send to devlin
lgtm with a bunch of mechanical changes. https://codereview.chromium.org/709813004/diff/40001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/709813004/diff/40001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode203 chrome/browser/chromeos/accessibility/accessibility_manager.cc:203: ->GetExtensionById( Slightly ...
6 years, 1 month ago (2014-11-11 20:20:09 UTC) #5
Reilly Grant (use Gerrit)
https://codereview.chromium.org/709813004/diff/40001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/709813004/diff/40001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode203 chrome/browser/chromeos/accessibility/accessibility_manager.cc:203: ->GetExtensionById( On 2014/11/11 20:20:08, kalman wrote: > Slightly better ...
6 years, 1 month ago (2014-11-11 20:55:32 UTC) #6
Reilly Grant (use Gerrit)
Lei, can you skim over the non-extensions parts of this?
6 years, 1 month ago (2014-11-11 20:58:31 UTC) #8
Lei Zhang
LGTM Thanks for doing this cleanup, comments are all nits: https://codereview.chromium.org/709813004/diff/100001/chrome/browser/ui/app_list/app_list_test_util.cc File chrome/browser/ui/app_list/app_list_test_util.cc (right): https://codereview.chromium.org/709813004/diff/100001/chrome/browser/ui/app_list/app_list_test_util.cc#newcode42 ...
6 years, 1 month ago (2014-11-11 22:09:23 UTC) #9
Reilly Grant (use Gerrit)
https://codereview.chromium.org/709813004/diff/100001/chrome/browser/ui/app_list/app_list_test_util.cc File chrome/browser/ui/app_list/app_list_test_util.cc (right): https://codereview.chromium.org/709813004/diff/100001/chrome/browser/ui/app_list/app_list_test_util.cc#newcode42 chrome/browser/ui/app_list/app_list_test_util.cc:42: ASSERT_EQ(static_cast<size_t>(5), registry()->enabled_extensions().size()); On 2014/11/11 22:09:22, Lei Zhang wrote: > ...
6 years, 1 month ago (2014-11-11 22:19:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709813004/120001
6 years, 1 month ago (2014-11-11 22:27:12 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:120001)
6 years, 1 month ago (2014-11-11 23:17:22 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 23:18:02 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/a3acbc189be0d9d5d7f37f218d8d8c124273d917
Cr-Commit-Position: refs/heads/master@{#303742}

Powered by Google App Engine
This is Rietveld 408576698