Remove the deprecated function ExtensionService::extensions().

chrome/browser/extensions/api/preference/preference_helpers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/preference/preference_helpers.h"
 
 #include "base/json/json_writer.h"
 #include "base/prefs/pref_service.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/preference/preference_api.h"
-#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_prefs.h"
-#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/common/manifest_handlers/incognito_info.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 namespace extensions {
 namespace preference_helpers {
 
 namespace {
 
 const char kIncognitoPersistent[] = "incognito_persistent";
 const char kIncognitoSessionOnly[] = "incognito_session_only";
@@ skipping 59 matching lines @@
 void DispatchEventToExtensions(
     Profile* profile,
     const std::string& event_name,
     base::ListValue* args,
     APIPermission::ID permission,
     bool incognito,
     const std::string& browser_pref) {
   EventRouter* router = EventRouter::Get(profile);
   if (!router || !router->HasEventListener(event_name))
     return;
-  ExtensionService* extension_service =
-      ExtensionSystem::Get(profile)->extension_service();
-  const ExtensionSet* extensions = extension_service->extensions();
-  for (ExtensionSet::const_iterator it = extensions->begin();
-       it != extensions->end(); ++it) {
-    std::string extension_id = (*it)->id();
+
+  for (const scoped_refptr<const extensions::Extension>& extension :
+       ExtensionRegistry::Get(profile)->enabled_extensions()) {
+    std::string extension_id = extension->id();

[not at google - send to devlin, 2014/11/11 20:20:09]

String copy here looks unnecessary.

[Reilly Grant (use Gerrit), 2014/11/11 20:55:31]

Done.

     // TODO(bauerb): Only iterate over registered event listeners.
     if (router->ExtensionHasEventListener(extension_id, event_name) &&
-        (*it)->permissions_data()->HasAPIPermission(permission) &&
-        (!incognito || IncognitoInfo::IsSplitMode(it->get()) ||
-         util::CanCrossIncognito(it->get(), profile))) {
+        extension->permissions_data()->HasAPIPermission(permission) &&
+        (!incognito || IncognitoInfo::IsSplitMode(extension.get()) ||
+         util::CanCrossIncognito(extension.get(), profile))) {
       // Inject level of control key-value.
       base::DictionaryValue* dict;
       bool rv = args->GetDictionary(0, &dict);
       DCHECK(rv);
       std::string level_of_control =

[not at google - send to devlin, 2014/11/11 20:20:09]

And apparently this whole API is pretty loose with its string copying. Ah well.

           GetLevelOfControl(profile, extension_id, browser_pref, incognito);
       dict->SetString(kLevelOfControlKey, level_of_control);
 
       // If the extension is in incognito split mode,
       // a) incognito pref changes are visible only to the incognito tabs
       // b) regular pref changes are visible only to the incognito tabs if the
       //    incognito pref has not alredy been set
       Profile* restrict_to_profile = NULL;
       bool from_incognito = false;
-      if (IncognitoInfo::IsSplitMode(it->get())) {
+      if (IncognitoInfo::IsSplitMode(extension.get())) {
         if (incognito &&
             util::IsIncognitoEnabled(extension_id, profile)) {
           restrict_to_profile = profile->GetOffTheRecordProfile();
         } else if (!incognito &&
                    PreferenceAPI::Get(profile)->DoesExtensionControlPref(
                        extension_id,
                        browser_pref,
                        &from_incognito) &&
                    from_incognito) {
           restrict_to_profile = profile;
         }
       }
 
       scoped_ptr<base::ListValue> args_copy(args->DeepCopy());
       scoped_ptr<Event> event(new Event(event_name, args_copy.Pass()));
       event->restrict_to_browser_context = restrict_to_profile;
       router->DispatchEventToExtension(extension_id, event.Pass());
     }
   }
 }
 
 }  // namespace preference_helpers
 }  // namespace extensions