Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 709753002: Fix scheduler for floating non-naked non-empty loops. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix scheduler for floating non-naked non-empty loops. R=jarin@chromium.org TEST=cctest/test-scheduler/NestedFloatingDiamondWithLoop Committed: https://code.google.com/p/v8/source/detail?r=25283

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M src/compiler/scheduler.cc View 1 2 3 chunks +26 lines, -1 line 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 1 month ago (2014-11-07 12:40:10 UTC) #1
Michael Starzinger
PTAL. Ready for review.
6 years, 1 month ago (2014-11-11 16:51:24 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-12 08:19:54 UTC) #3
Michael Starzinger
6 years, 1 month ago (2014-11-12 09:38:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 25283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698