Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: test/cctest/compiler/test-scheduler.cc

Issue 709753002: Fix scheduler for floating non-naked non-empty loops. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased again. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/scheduler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-scheduler.cc
diff --git a/test/cctest/compiler/test-scheduler.cc b/test/cctest/compiler/test-scheduler.cc
index 191d120e79c27fd76f8e9668889dbf66ed2a13b9..0f7e248efb2ee88d1939b2277a3d708d3ebe75ff 100644
--- a/test/cctest/compiler/test-scheduler.cc
+++ b/test/cctest/compiler/test-scheduler.cc
@@ -1825,10 +1825,8 @@ TEST(NestedFloatingDiamondWithLoop) {
Node* loop = graph.NewNode(common.Loop(2), f, start);
Node* ind = graph.NewNode(common.Phi(kMachAnyTagged, 2), p0, p0, loop);
- // TODO(mstarzinger): Make scheduler deal with non-empty loops here.
- // Node* add = graph.NewNode(&kIntAdd, ind, fv);
-
- Node* br1 = graph.NewNode(common.Branch(), ind, loop);
+ Node* add = graph.NewNode(&kIntAdd, ind, fv);
+ Node* br1 = graph.NewNode(common.Branch(), add, loop);
Node* t1 = graph.NewNode(common.IfTrue(), br1);
Node* f1 = graph.NewNode(common.IfFalse(), br1);
@@ -1843,7 +1841,7 @@ TEST(NestedFloatingDiamondWithLoop) {
graph.SetEnd(end);
- ComputeAndVerifySchedule(19, &graph);
+ ComputeAndVerifySchedule(20, &graph);
}
« no previous file with comments | « src/compiler/scheduler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698