Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: Source/bindings/core/v8/custom/V8ElementCustom.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8ElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ElementCustom.cpp b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
index 270d2fc535c067de13e755f14bec1371dd62e00e..dfe4ab6d146662606a6f9280b01432110d8706aa 100644
--- a/Source/bindings/core/v8/custom/V8ElementCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8ElementCustom.cpp
@@ -118,7 +118,7 @@ void animate4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
TONATIVE_VOID(AnimationEffect*, effect, V8AnimationEffect::toImplWithTypeCheck(info.GetIsolate(), info[0]));
TONATIVE_VOID(Dictionary, timingInput, Dictionary(info[1], info.GetIsolate()));
if (!timingInput.isUndefinedOrNull() && !timingInput.isObject()) {
- V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("animate", "Element", "parameter 2 ('timingInput') is not an object."), info.GetIsolate());
+ V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("animate", "Element", "parameter 2 ('timingInput') is not an object."));
return;
}
v8SetReturnValueFast(info, WTF::getPtr(ElementAnimation::animate(*impl, effect, timingInput)), impl);
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.cpp ('k') | Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698