Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: Source/bindings/core/v8/V8ThrowException.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | Source/bindings/core/v8/custom/V8ElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ThrowException.cpp
diff --git a/Source/bindings/core/v8/V8ThrowException.cpp b/Source/bindings/core/v8/V8ThrowException.cpp
index 67a47c1b8e5d8b93e64d7ad24610ab699fe0673f..060ab6b784f6121f0c58c296cd40913009f77dc3 100644
--- a/Source/bindings/core/v8/V8ThrowException.cpp
+++ b/Source/bindings/core/v8/V8ThrowException.cpp
@@ -44,7 +44,7 @@ static void domExceptionStackSetter(v8::Local<v8::String> name, v8::Local<v8::Va
info.Data()->ToObject()->Set(v8AtomicString(info.GetIsolate(), "stack"), value);
}
-v8::Handle<v8::Value> V8ThrowException::createDOMException(int ec, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::createDOMException(v8::Isolate* isolate, int ec, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext)
{
if (ec <= 0 || v8::V8::IsExecutionTerminating())
return v8Undefined();
@@ -81,7 +81,7 @@ v8::Handle<v8::Value> V8ThrowException::createDOMException(int ec, const String&
v8::Handle<v8::Value> V8ThrowException::throwDOMException(int ec, const String& sanitizedMessage, const String& unsanitizedMessage, const v8::Handle<v8::Object>& creationContext, v8::Isolate* isolate)
{
ASSERT(ec == SecurityError || unsanitizedMessage.isEmpty());
- v8::Handle<v8::Value> exception = createDOMException(ec, sanitizedMessage, unsanitizedMessage, creationContext, isolate);
+ v8::Handle<v8::Value> exception = createDOMException(isolate, ec, sanitizedMessage, unsanitizedMessage, creationContext);
if (exception.IsEmpty())
return v8Undefined();
@@ -104,7 +104,7 @@ v8::Handle<v8::Value> V8ThrowException::createTypeError(v8::Isolate* isolate, co
return v8::Exception::TypeError(v8String(isolate, message.isNull() ? "Type error" : message));
}
-v8::Handle<v8::Value> V8ThrowException::throwTypeError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::throwTypeError(v8::Isolate* isolate, const String& message)
{
v8::Handle<v8::Value> exception = V8ThrowException::createTypeError(isolate, message);
return V8ThrowException::throwException(exception, isolate);
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | Source/bindings/core/v8/custom/V8ElementCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698