Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709603006: Remove a bunch of OS(MACOSX) code (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
ojan, abarth-chromium
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a bunch of OS(MACOSX) code This code is unused in sky. Amazing how much code we had for dealing with old versions of MSVC. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5a34c87a32ebd64a708990eebdb93c4a518ac132

Patch Set 1 #

Patch Set 2 : More MACOSX #

Patch Set 3 : Even more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -759 lines) Patch
M sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 chunks +0 lines, -28 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/LayoutUnit.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/PlatformWheelEvent.h View 5 chunks +0 lines, -50 lines 0 comments Download
M sky/engine/platform/fonts/Font.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/fonts/FontCache.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/fonts/FontCustomPlatformData.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/platform/fonts/SimpleFontData.h View 6 chunks +0 lines, -30 lines 0 comments Download
M sky/engine/platform/geometry/FloatPoint.h View 2 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/platform/geometry/FloatRect.h View 2 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/platform/geometry/FloatSize.h View 1 2 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/platform/geometry/IntPoint.h View 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/platform/geometry/IntRect.h View 1 2 3 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/platform/geometry/IntSize.h View 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.cpp View 7 chunks +0 lines, -90 lines 0 comments Download
M sky/engine/platform/image-decoders/ImageDecoder.h View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/wtf/Assertions.cpp View 1 2 2 chunks +2 lines, -72 lines 0 comments Download
M sky/engine/wtf/MathExtras.h View 4 chunks +1 line, -148 lines 0 comments Download
M sky/engine/wtf/StringExtras.h View 1 2 1 chunk +0 lines, -60 lines 1 comment Download
M sky/engine/wtf/ThreadingPthreads.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/wtf/text/ASCIIFastPath.h View 1 2 chunks +1 line, -35 lines 0 comments Download
M sky/engine/wtf/unicode/icu/CollatorICU.cpp View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
eseidel
6 years, 1 month ago (2014-11-11 23:04:48 UTC) #1
ojan
lgtm
6 years, 1 month ago (2014-11-11 23:17:24 UTC) #3
eseidel
Added a little more. PTAL.
6 years, 1 month ago (2014-11-11 23:19:31 UTC) #4
eseidel
Committed patchset #3 (id:40001) manually as 5a34c87a32ebd64a708990eebdb93c4a518ac132 (presubmit successful).
6 years, 1 month ago (2014-11-11 23:33:42 UTC) #5
ojan
6 years, 1 month ago (2014-11-11 23:35:48 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/709603006/diff/40001/sky/engine/wtf/StringExt...
File sky/engine/wtf/StringExtras.h (left):

https://codereview.chromium.org/709603006/diff/40001/sky/engine/wtf/StringExt...
sky/engine/wtf/StringExtras.h:33: #if !defined(HAVE_STRNSTR)
Do we know this is always false?

Powered by Google App Engine
This is Rietveld 408576698