Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: sky/engine/web/WebViewImpl.cpp

Issue 709603006: Remove a bunch of OS(MACOSX) code (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Even more Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/WebViewImpl.cpp
diff --git a/sky/engine/web/WebViewImpl.cpp b/sky/engine/web/WebViewImpl.cpp
index 9abb54cf2370473cd9864230c050d982efdea980..29c258d614308298939390ce94b493ebaca7eeef 100644
--- a/sky/engine/web/WebViewImpl.cpp
+++ b/sky/engine/web/WebViewImpl.cpp
@@ -748,15 +748,6 @@ bool WebViewImpl::keyEventDefault(const WebKeyboardEvent& event)
case WebInputEvent::RawKeyDown:
if (event.modifiers == WebInputEvent::ControlKey) {
switch (event.windowsKeyCode) {
-#if !OS(MACOSX)
- case 'A':
- focusedFrame()->executeCommand(WebString::fromUTF8("SelectAll"));
- return true;
- case VKEY_INSERT:
- case 'C':
- focusedFrame()->executeCommand(WebString::fromUTF8("Copy"));
- return true;
-#endif
// Match FF behavior in the sense that Ctrl+home/end are the only Ctrl
// key combinations which affect scrolling. Safari is buggy in the
// sense that it scrolls the page for all Ctrl+scrolling key
@@ -781,15 +772,6 @@ bool WebViewImpl::scrollViewWithKeyboard(int keyCode, int modifiers)
{
ScrollDirection scrollDirection;
ScrollGranularity scrollGranularity;
-#if OS(MACOSX)
- // Control-Up/Down should be PageUp/Down on Mac.
- if (modifiers & WebMouseEvent::ControlKey) {
- if (keyCode == VKEY_UP)
- keyCode = VKEY_PRIOR;
- else if (keyCode == VKEY_DOWN)
- keyCode = VKEY_NEXT;
- }
-#endif
if (!mapKeyCodeForScroll(keyCode, &scrollDirection, &scrollGranularity))
return false;

Powered by Google App Engine
This is Rietveld 408576698