Move mojo/apps/js tests et al to mojo/edk/js/test,tests

Move mojo/apps/js tests et al to mojo/edk/js/test,tests

The apps_js_unitttests test executable is now called js_integration_tests.

The connection_unittests are now included in the JS unittests. To enable that the threading module, which just provides a quit method, was added to mojo/public/js. Its implementation is mojo/edk/js.

Integration tests are in the edk/js/tests directory and test support code is in edk/js/test.




BUG=430520
R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c60368c4442458f2d53e7cd199003624ff6fbc3f

[hansmuller, 2014-11-07 00:38:07]

hansmuller@chromium.org changed reviewers:
+ jamesr@chromium.org

[hansmuller, 2014-11-07 01:07:22]

PTAL.

Note:the gyp build doesn't yet include js_integration_tests, i.e. the tests
defined in mojo/edk/js/tests.

[jamesr, 2014-11-07 01:24:37]

lgtm

+eseidel@ as fyi - i think this collides a bit with your gn check patch and IMO
this one should land first, since it's bigger and likely to bitrot first.

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/BUILD.gn
File mojo/edk/js/test/BUILD.gn (right):

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/BUILD.g...
mojo/edk/js/test/BUILD.gn:20: deps = [
this should probably declare a dependency on //base, right?

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/run_js_...
File mojo/edk/js/test/run_js_integration_tests.cc (right):

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/run_js_...
mojo/edk/js/test/run_js_integration_tests.cc:5: #include
"base/files/file_path.h"
yeah this target definitely uses //base

[hansmuller, 2014-11-07 15:36:02]

Committed patchset #3 (id:40001) manually as
c60368c4442458f2d53e7cd199003624ff6fbc3f (presubmit successful).

[hansmuller, 2014-11-07 15:40:52]

This is the last big Mojo JS move. Still to go: the JS content handler, GL and
the monotonic_clock bindings.

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/BUILD.gn
File mojo/edk/js/test/BUILD.gn (right):

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/BUILD.g...
mojo/edk/js/test/BUILD.gn:20: deps = [
On 2014/11/07 01:24:37, jamesr wrote:
> this should probably declare a dependency on //base, right?

You're right, both test runner applications depend on base. I've added the
dependency.

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/run_js_...
File mojo/edk/js/test/run_js_integration_tests.cc (right):

https://codereview.chromium.org/709603002/diff/40001/mojo/edk/js/test/run_js_...
mojo/edk/js/test/run_js_integration_tests.cc:5: #include
"base/files/file_path.h"
On 2014/11/07 01:24:37, jamesr wrote:
> yeah this target definitely uses //base

Acknowledged.