Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: mojo/apps/js/test/run_apps_js_tests.cc

Issue 709603002: Move mojo/apps/js tests et al to mojo/edk/js/test,tests (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: chromium environment for JS tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/apps/js/test/run_apps_js_tests.cc
diff --git a/mojo/apps/js/test/run_apps_js_tests.cc b/mojo/apps/js/test/run_apps_js_tests.cc
index 3ccfd7191a153ff986d978ae15c80a8093ac2854..5d599a53cd7e9432a17006f31b9321591b87627f 100644
--- a/mojo/apps/js/test/run_apps_js_tests.cc
+++ b/mojo/apps/js/test/run_apps_js_tests.cc
@@ -10,7 +10,6 @@
#include "gin/test/file_runner.h"
#include "gin/test/gtest.h"
#include "mojo/apps/js/bindings/monotonic_clock.h"
-#include "mojo/apps/js/bindings/threading.h"
#include "mojo/edk/js/core.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -26,7 +25,6 @@ class TestRunnerDelegate : public gin::FileRunnerDelegate {
AddBuiltinModule(gin::TimerModule::kName, gin::TimerModule::GetModule);
AddBuiltinModule(apps::MonotonicClock::kModuleName,
apps::MonotonicClock::GetModule);
- AddBuiltinModule(apps::Threading::kModuleName, apps::Threading::GetModule);
}
private:
@@ -47,14 +45,6 @@ void RunTest(std::string test, bool run_until_idle) {
// TODO(abarth): Should we autogenerate these stubs from GYP?
-TEST(JSTest, sample_test) {
- RunTest("sample_service_unittests.js", true);
-}
-
-TEST(JSTest, connection) {
- RunTest("connection_unittests.js", false);
-}
-
TEST(JSTest, monotonic_clock) {
RunTest("monotonic_clock_unittests.js", false);
}

Powered by Google App Engine
This is Rietveld 408576698