sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp - Issue 709503003: Remove RenderObject::isVideo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp

Issue 709503003: Remove RenderObject::isVideo (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp ('k') | sky/engine/platform/graphics/CompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp

diff --git a/sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp b/sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp

index 2d1c31f3781e12bf3b68fee125ac74353bd4710e..7bd6334468187afdb3b38387d55306a1f3a11d87 100644

--- a/sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp

+++ b/sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp

@@ -213,13 +213,6 @@ void CompositingRequirementsUpdater::updateRecursive(RenderLayer* ancestorLayer,

CompositingReasons reasonsToComposite = CompositingReasonNone;

CompositingReasons directReasons = m_compositingReasonFinder.directReasons(layer);

- // Video is special. It's the only RenderLayer type that can both have

- // RenderLayer children and whose children can't use its backing to render

- // into. These children (the controls) always need to be promoted into their

- // own layers to draw on top of the accelerated video.

- if (currentRecursionData.m_compositingAncestor && currentRecursionData.m_compositingAncestor->renderer()->isVideo())

- directReasons |= CompositingReasonVideoOverlay;

if (compositor->canBeComposited(layer))

reasonsToComposite |= directReasons;