Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2577)

Unified Diff: sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp

Issue 709503003: Remove RenderObject::isVideo (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp
diff --git a/sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp b/sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp
index de9a81fcdc853f2c9aea1502af949765e4b34e92..0d24cab737f30d6f5567dfb14392d6765c24e785 100644
--- a/sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp
+++ b/sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp
@@ -120,16 +120,6 @@ CompositingReasons CompositingLayerAssigner::getReasonsPreventingSquashing(const
if (!squashingState.haveAssignedBackingsToEntireSquashingLayerSubtree)
return CompositingReasonSquashingWouldBreakPaintOrder;
- // FIXME: this special case for video exists only to deal with corner cases
- // where a RenderVideo does not report that it needs to be directly composited.
- // Video does not currently support sharing a backing, but this could be
- // generalized in the future. The following layout tests fail if we permit the
- // video to share a backing with other layers.
- //
- // compositing/video/video-controls-layer-creation.html
- if (layer->renderer()->isVideo())
- return CompositingReasonSquashingVideoIsDisallowed;
-
if (squashingWouldExceedSparsityTolerance(layer, squashingState))
return CompositingReasonSquashingSparsityExceeded;

Powered by Google App Engine
This is Rietveld 408576698