Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 709473002: Detect loops overflow for gpu benches. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Detect loops overflow for gpu benches. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/527930fdbbba2a20f98b43821c6b72367e7b2d64

Patch Set 1 #

Patch Set 2 : 30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M bench/nanobench.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein
Can you patch this on top of the nvpr concics and see if we get ...
6 years, 1 month ago (2014-11-06 14:57:06 UTC) #2
mtklein
Fixed overflow check.
6 years, 1 month ago (2014-11-06 15:48:21 UTC) #3
egdaniel
lgtm
6 years, 1 month ago (2014-11-06 15:50:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709473002/20001
6 years, 1 month ago (2014-11-06 15:53:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709473002/20001
6 years, 1 month ago (2014-11-06 16:04:30 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 16:04:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 527930fdbbba2a20f98b43821c6b72367e7b2d64

Powered by Google App Engine
This is Rietveld 408576698