Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 709433002: Revert of content: Cleanup GpuMemoryBuffers when child process is removed. (Closed)

Created:
6 years, 1 month ago by yhirano
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gpu-memory-buffer-id-refactor
Project:
chromium
Visibility:
Public.

Description

Revert of content: Cleanup GpuMemoryBuffers when child process is removed. (patchset #5 id:80001 of https://codereview.chromium.org/703463005/) Reason for revert: Blink layout tests are failing and this CL might be the cause. Let me revert this CL. Original issue's description: > content: Cleanup GpuMemoryBuffers when child process is removed. > > This keeps track of buffers allocated for child processes in > BrowserGpuMemoryBufferManager and makes sure > GpuMemoryBufferImpl::DeletedByChildProcess is called > appropriately when a process is removed. > > BUG= > > Committed: https://crrev.com/32e22ea8b72f52ac89e5d5720d1a26596f015caf > Cr-Commit-Position: refs/heads/master@{#302968} TBR=piman@chromium.org,alexst@chromium.org,kenrb@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d1f3f55d090788dcb09321e6425fc953ac40ee0a Cr-Commit-Position: refs/heads/master@{#302984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -136 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 2 chunks +2 lines, -14 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 4 chunks +21 lines, -109 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
Created Revert of content: Cleanup GpuMemoryBuffers when child process is removed.
6 years, 1 month ago (2014-11-06 08:24:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709433002/1
6 years, 1 month ago (2014-11-06 08:25:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 08:26:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d1f3f55d090788dcb09321e6425fc953ac40ee0a Cr-Commit-Position: refs/heads/master@{#302984}
6 years, 1 month ago (2014-11-06 08:26:42 UTC) #4
reveman
On 2014/11/06 08:24:02, yhirano wrote: > Created Revert of content: Cleanup GpuMemoryBuffers when child process ...
6 years, 1 month ago (2014-11-06 15:26:34 UTC) #5
yhirano
6 years, 1 month ago (2014-11-06 15:56:32 UTC) #6
Message was sent while issue was closed.
On 2014/11/06 15:26:34, reveman wrote:
> On 2014/11/06 08:24:02, yhirano wrote:
> > Created Revert of content: Cleanup GpuMemoryBuffers when child process is
> > removed.
> 
> Did this revert fix the layout tests? In that case, what was the failure?

I pasted links to the original CL.

Powered by Google App Engine
This is Rietveld 408576698