Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: content/child/child_gpu_memory_buffer_manager.cc

Issue 709433002: Revert of content: Cleanup GpuMemoryBuffers when child process is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gpu-memory-buffer-id-refactor
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/child_gpu_memory_buffer_manager.h" 5 #include "content/child/child_gpu_memory_buffer_manager.h"
6 6
7 #include "content/child/child_thread.h" 7 #include "content/child/child_thread.h"
8 #include "content/common/child_process_messages.h" 8 #include "content/common/child_process_messages.h"
9 #include "content/common/gpu/client/gpu_memory_buffer_impl.h" 9 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
10 10
11 namespace content { 11 namespace content {
12 namespace { 12 namespace {
13 13
14 void DeletedGpuMemoryBuffer(ThreadSafeSender* sender, 14 void DeletedGpuMemoryBuffer(ThreadSafeSender* sender,
15 gfx::GpuMemoryBufferType type,
15 gfx::GpuMemoryBufferId id, 16 gfx::GpuMemoryBufferId id,
16 uint32 sync_point) { 17 uint32 sync_point) {
17 TRACE_EVENT0("renderer", 18 TRACE_EVENT0("renderer",
18 "ChildGpuMemoryBufferManager::DeletedGpuMemoryBuffer"); 19 "ChildGpuMemoryBufferManager::DeletedGpuMemoryBuffer");
19 sender->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(id, sync_point)); 20 sender->Send(
21 new ChildProcessHostMsg_DeletedGpuMemoryBuffer(type, id, sync_point));
20 } 22 }
21 23
22 } // namespace 24 } // namespace
23 25
24 ChildGpuMemoryBufferManager::ChildGpuMemoryBufferManager( 26 ChildGpuMemoryBufferManager::ChildGpuMemoryBufferManager(
25 ThreadSafeSender* sender) 27 ThreadSafeSender* sender)
26 : sender_(sender) { 28 : sender_(sender) {
27 } 29 }
28 30
29 ChildGpuMemoryBufferManager::~ChildGpuMemoryBufferManager() { 31 ChildGpuMemoryBufferManager::~ChildGpuMemoryBufferManager() {
(...skipping 15 matching lines...) Expand all
45 IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer( 47 IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer(
46 size.width(), size.height(), format, usage, &handle); 48 size.width(), size.height(), format, usage, &handle);
47 bool success = sender_->Send(message); 49 bool success = sender_->Send(message);
48 if (!success) 50 if (!success)
49 return scoped_ptr<gfx::GpuMemoryBuffer>(); 51 return scoped_ptr<gfx::GpuMemoryBuffer>();
50 52
51 scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle( 53 scoped_ptr<GpuMemoryBufferImpl> buffer(GpuMemoryBufferImpl::CreateFromHandle(
52 handle, 54 handle,
53 size, 55 size,
54 format, 56 format,
55 base::Bind(&DeletedGpuMemoryBuffer, sender_, handle.id))); 57 base::Bind(&DeletedGpuMemoryBuffer, sender_, handle.type, handle.id)));
56 if (!buffer) { 58 if (!buffer) {
57 sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(handle.id, 0)); 59 sender_->Send(new ChildProcessHostMsg_DeletedGpuMemoryBuffer(
60 handle.type, handle.id, 0));
58 return scoped_ptr<gfx::GpuMemoryBuffer>(); 61 return scoped_ptr<gfx::GpuMemoryBuffer>();
59 } 62 }
60 63
61 return buffer.Pass(); 64 return buffer.Pass();
62 } 65 }
63 66
64 gfx::GpuMemoryBuffer* 67 gfx::GpuMemoryBuffer*
65 ChildGpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer( 68 ChildGpuMemoryBufferManager::GpuMemoryBufferFromClientBuffer(
66 ClientBuffer buffer) { 69 ClientBuffer buffer) {
67 return GpuMemoryBufferImpl::FromClientBuffer(buffer); 70 return GpuMemoryBufferImpl::FromClientBuffer(buffer);
68 } 71 }
69 72
70 void ChildGpuMemoryBufferManager::SetDestructionSyncPoint( 73 void ChildGpuMemoryBufferManager::SetDestructionSyncPoint(
71 gfx::GpuMemoryBuffer* buffer, 74 gfx::GpuMemoryBuffer* buffer,
72 uint32 sync_point) { 75 uint32 sync_point) {
73 static_cast<GpuMemoryBufferImpl*>(buffer) 76 static_cast<GpuMemoryBufferImpl*>(buffer)
74 ->set_destruction_sync_point(sync_point); 77 ->set_destruction_sync_point(sync_point);
75 } 78 }
76 79
77 } // namespace content 80 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_unittest.cc ('k') | content/common/child_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698