Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709203002: Remove more oilpan. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove more oilpan. I also unraveled lots of transitive deps from Handle.h R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/189bd00b0bed10292553f4bb898597b8657a0001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -314 lines) Patch
M sky/engine/core/animation/ActiveAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationPlayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/InterpolableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/SampledEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSTimingData.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSCanvasValue.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/css/CSSDefaultStyleSheets.h View 2 chunks +3 lines, -6 lines 0 comments Download
M sky/engine/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/css/CSSFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSFontFaceSource.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSFontSelectorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSKeyframeRule.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSRuleList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSValuePool.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/FontFaceSetForEachCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/MediaQuery.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/MediaQueryExp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/MediaQueryList.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/RuleSet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/css/StyleRule.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/invalidation/StyleInvalidator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/css/resolver/MatchedPropertiesCache.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/MediaQueryResult.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/DOMSettableTokenList.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DOMTokenList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DocumentMarkerController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DocumentTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/dom/ElementData.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ElementDataCache.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/IncrementLoadEventDelayCount.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/MutationObserverInterestGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/MutationObserverRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/NodeRareData.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/RequestAnimationFrameCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ShadowTreeStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StyleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/TreeScope.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/TreeShared.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskRunQueue.h View 2 chunks +3 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementScheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ShadowRootRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/Caret.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/FrameSelection.h View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/editing/UndoStack.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/VisibleSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/DOMWindowEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/EventFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/EventPath.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/EventQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/EventTarget.h View 2 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/events/GenericEventQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/fetch/MemoryCache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/fetch/Resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/fetch/ResourceLoaderHost.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/fetch/ResourceLoaderSet.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/EventHandlerRegistry.h View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/frame/FrameHost.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/frame/ImageBitmap.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/VoidCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/Canvas2DContextAttributes.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/canvas/HitRegion.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/Path2D.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLContextObject.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLContextObject.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLExtension.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/canvas/WebGLFramebuffer.h View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLFramebuffer.cpp View 6 chunks +1 line, -24 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLProgram.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLProgram.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderbuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.h View 3 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImport.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/imports/HTMLImportChildClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportsController.h View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/inspector/ConsoleMessageStorage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/loader/ImageLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/page/Page.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObjectChildList.h View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderObjectChildList.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderSelectionInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/testing/NullExecutionContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 3 chunks +1 line, -24 lines 0 comments Download
M sky/engine/platform/image-decoders/ImageDecoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/ListHashSet.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
6 years, 1 month ago (2014-11-08 02:07:00 UTC) #2
esprehn
6 years, 1 month ago (2014-11-08 02:11:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
189bd00b0bed10292553f4bb898597b8657a0001.

Powered by Google App Engine
This is Rietveld 408576698