Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 709123005: [arm] Recognize SXTB, SXTH, UXTB and UXTH. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[arm] Recognize SXTB, SXTH, UXTB and UXTH. TEST=cctest,msjunit/asm,unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1136 lines, -172 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +12 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +96 lines, -48 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +131 lines, -29 lines 0 comments Download
M src/arm/simulator-arm.cc View 3 chunks +160 lines, -38 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 7 chunks +160 lines, -38 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 2 chunks +211 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +26 lines, -8 lines 0 comments Download
A test/mjsunit/asm/sign-extend.js View 1 chunk +45 lines, -0 lines 0 comments Download
A test/mjsunit/asm/zero-extend.js View 1 chunk +37 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 2 chunks +210 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-10 05:28:23 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-10 05:47:54 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-10 05:48:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25228 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698