Issue 709123002: Revert "Avoid some unnecessary fast-properties map creations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 709123002: Revert "Avoid some unnecessary fast-properties map creations." (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)

Modified:
6 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Avoid some unnecessary fast-properties map creations." This reverts commit e1f23eab4255d63344011dfb885b8e8962cb60e2. Broke cctest/test-heap/ReleaseOverReservedPages on a bunch of builders http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/928/steps/Check/logs/ReleaseOverReservedPa.. BUG=None LOG=N TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25224

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	src/objects.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/object-freeze.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-137689.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

arv (Not doing code reviews)

Committed patchset #1 (id:1) manually as 25224 (tree was closed).

6 years, 1 month ago (2014-11-07 18:49:30 UTC) #1

Message was sent while issue was closed.

lgtm