src/runtime/runtime-object.cc - Issue 709123002: Revert "Avoid some unnecessary fast-properties map creations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 709123002: Revert "Avoid some unnecessary fast-properties map creations." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 524c88451dad3e773ab20065e03e083ed5c8a89b..b2a736d7a5bb41e07532366ac815da3693bcbace 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -1455,8 +1455,10 @@ RUNTIME_FUNCTION(Runtime_DefineAccessorPropertyUnchecked) {

RUNTIME_ASSERT((unchecked & ~(READ_ONLY | DONT_ENUM | DONT_DELETE)) == 0);

PropertyAttributes attr = static_cast<PropertyAttributes>(unchecked);

+ bool fast = obj->HasFastProperties();

RETURN_FAILURE_ON_EXCEPTION(

isolate, JSObject::DefineAccessor(obj, name, getter, setter, attr));

+ if (fast) JSObject::MigrateSlowToFast(obj, 0, "RuntimeDefineAccessor");

return isolate->heap()->undefined_value();

}

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/object-freeze.js » ('j') | no next file with comments »