Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 708993002: Revert "Use remove_build_metadata.py on all the trybots (take 2)." (Closed)

Created:
6 years, 1 month ago by Paweł Hajdan Jr.
Modified:
6 years, 1 month ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Revert "Use remove_build_metadata.py on all the trybots (take 2)." Original CL https://codereview.chromium.org/680253003 TBR=sebmarchand@chromium.org BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292881

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
It seems to be breaking telemetry tests on Windows (on a bot that has been ...
6 years, 1 month ago (2014-11-07 10:50:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708993002/1
6 years, 1 month ago (2014-11-07 10:51:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 292881
6 years, 1 month ago (2014-11-07 10:52:37 UTC) #4
Sébastien Marchand
There's really no reason for this step to cause this kind of failures, all it ...
6 years, 1 month ago (2014-11-07 11:37:10 UTC) #5
Paweł Hajdan Jr.
6 years, 1 month ago (2014-11-07 11:44:02 UTC) #6
Message was sent while issue was closed.
On 2014/11/07 11:37:10, Sébastien Marchand wrote:
> There's really no reason for this step to cause this kind of failures, all it
> does is removing some timestamps contained in the .exe and .dll, at this it's
> point the image should work as expected or not at all.... I'll see if I can
> reproduce this locally.

Builds are apparently succeeding right after removing this step:
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...

It might still be coincidence, I'll keep monitoring.

Main takeaway as far as I'm concerned: please coordinate with me or other CQ
focus area folks. We've been changing tryservers used by CQ, so this breakage
went undetected for longer than it should.

Powered by Google App Engine
This is Rietveld 408576698