Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 708993002: Revert "Use remove_build_metadata.py on all the trybots (take 2)." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'chromium', 7 'chromium',
8 'chromium_tests', 8 'chromium_tests',
9 'gclient', 9 'gclient',
10 'isolate', 10 'isolate',
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra 915 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra
916 # compile failures. We've seen cases of compile with patch failing 916 # compile failures. We've seen cases of compile with patch failing
917 # with build steps getting killed, compile without patch succeeding, 917 # with build steps getting killed, compile without patch succeeding,
918 # and compile with patch succeeding on another attempt with same patch. 918 # and compile with patch succeeding on another attempt with same patch.
919 except api.step.StepFailure: 919 except api.step.StepFailure:
920 api.tryserver.set_transient_failure_tryjob_result() 920 api.tryserver.set_transient_failure_tryjob_result()
921 raise 921 raise
922 raise 922 raise
923 923
924 if bot_config.get('use_isolate') or has_swarming_tests: 924 if bot_config.get('use_isolate') or has_swarming_tests:
925 # Remove the build metadata from the binaries. Currently it's a noop on 925 # TODO(sebmarchand): remove_build_metadata, http://crbug.com/314403 .
926 # all platforms except Windows where it run zap_timestamp.exe on all the
927 # PE images.
928 api.isolate.remove_build_metadata()
929 # Isolate all prepared targets, will look for *.isolated.gen.json files. 926 # Isolate all prepared targets, will look for *.isolated.gen.json files.
930 api.isolate.isolate_tests(api.chromium.output_dir, verbose=True) 927 api.isolate.isolate_tests(api.chromium.output_dir, verbose=True)
931 928
932 if bot_config['compile_only']: 929 if bot_config['compile_only']:
933 tests = [] 930 tests = []
934 931
935 return tests, bot_update_step 932 return tests, bot_update_step
936 933
937 mastername = api.properties.get('mastername') 934 mastername = api.properties.get('mastername')
938 buildername = api.properties.get('buildername') 935 buildername = api.properties.get('buildername')
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 'test': 'base_tests', 1595 'test': 'base_tests',
1599 'args': ['--gtest-filter: *NaCl*.*'], 1596 'args': ['--gtest-filter: *NaCl*.*'],
1600 }, 1597 },
1601 ], 1598 ],
1602 }) 1599 })
1603 ) + 1600 ) +
1604 api.override_step_data( 1601 api.override_step_data(
1605 'analyze', 1602 'analyze',
1606 api.json.output({'invalid_targets': 'invalid target'})) 1603 api.json.output({'invalid_targets': 'invalid target'}))
1607 ) 1604 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698