Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 708713004: Improve logic in ensureDefaultStyleSheetsForElement (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Improve logic in ensureDefaultStyleSheetsForElement Improve logic in ensureDefaultStyleSheetsForElement, there is no need for example to test namespace for Mathml if we already established the element is an SVG element. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +25 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL. BTW I don't know how those FIXMEs should be interpreted, for instance both the ...
6 years, 1 month ago (2014-11-11 19:52:45 UTC) #2
rwlbuis
On 2014/11/11 19:52:45, rwlbuis wrote: > PTAL. BTW I don't know how those FIXMEs should ...
6 years ago (2014-12-01 19:15:17 UTC) #3
esprehn
lgtm, the FIXME is hard to fix without some kind of compile assert.
6 years ago (2014-12-01 19:47:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708713004/1
6 years ago (2014-12-01 20:57:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186262
6 years ago (2014-12-01 22:22:00 UTC) #7
Ken Russell (switch to Gerrit)
6 years ago (2014-12-02 01:13:55 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/770103002/ by kbr@chromium.org.

The reason for reverting is: Seems to be the cause of assertion failures like:
crash log for renderer (pid 30072):
STDOUT: #CRASHED - renderer (pid 30072)
STDERR: Xlib:  extension "RANDR" missing on display ":9".
STDERR: [30072:30072:1017/090946:3443219798580:ERROR:renderer_main.cc(227)]
Running without renderer sandbox
STDERR: [30090:30090:1017/090946:3443219850178:ERROR:renderer_main.cc(227)]
Running without renderer sandbox
STDERR: ASSERTION FAILED: !value || (value->isInitialValue())
STDERR: ../../third_party/WebKit/Source/core/css/CSSLineBoxContainValue.h(59) :
const WebCore::CSSLineBoxContainValue* WebCore::toCSSLineBoxContainValue(const
WebCore::CSSValue*)


Example failing build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28db...

Please file bugs for changes like this in the future so there is a permanent
record of any reverts and re-lands..

Powered by Google App Engine
This is Rietveld 408576698