chrome/browser/resources/options/chromeos/internet_detail.html - Issue 708563005: Use setProperties for IP Config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.html

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1

Patch Set: Add managed indicator to userNameServers, feedback, fix tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/browser/resources/options/chromeos/internet_detail.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/internet_detail.html

diff --git a/chrome/browser/resources/options/chromeos/internet_detail.html b/chrome/browser/resources/options/chromeos/internet_detail.html

index 788c41ae149a7d1f6b909f48503bbfa3f1fb02df..05271a6d3b71bb4bb5057f046a542f804aaf0f96 100644

--- a/chrome/browser/resources/options/chromeos/internet_detail.html

+++ b/chrome/browser/resources/options/chromeos/internet_detail.html

@@ -409,7 +409,7 @@

<span>

<span class="controlled-setting-indicator"

- managed="StaticIPConfig.IPAddress"></span>

+ managed="IPConfigType"></span>

pneubeck (no reviews) 2015/01/08 09:47:13 IPAddressConfigType

stevenjb 2015/01/08 17:09:58 Oops, thanks. Done. Also did a grep, no other miss

</span>

</label>

</div>

@@ -454,7 +454,11 @@

<label>

<input id="user-dns-radio" type="radio" name="dnstype"

value="user">

- <span i18n-content="userNameServers"></span>

+ <span>

+ <span i18n-content="userNameServers"></span>

+ <span class="controlled-setting-indicator"

+ managed="NameServersConfigType"></span>

+ </span>

</label>

</div>