Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: chrome/browser/resources/options/chromeos/internet_detail.html

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1
Patch Set: Add managed indicator to userNameServers, feedback, fix tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <div id="details-internet-page" class="page" hidden> 1 <div id="details-internet-page" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <!-- Network header --> 3 <!-- Network header -->
4 <div id="network-details-header"> 4 <div id="network-details-header">
5 <div id="network-details-title"></div> 5 <div id="network-details-title"></div>
6 <div id="network-details-subtitle"> 6 <div id="network-details-subtitle">
7 <span id="network-details-subtitle-status"></span> 7 <span id="network-details-subtitle-status"></span>
8 <span id="network-details-subtitle-separator"> - </span> 8 <span id="network-details-subtitle-separator"> - </span>
9 <span id="network-details-subtitle-type"></span> 9 <span id="network-details-subtitle-type"></span>
10 </div> 10 </div>
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 </section> 402 </section>
403 <section id="ipconfig-section"> 403 <section id="ipconfig-section">
404 <div id="ip-automatic-configuration" 404 <div id="ip-automatic-configuration"
405 class="checkbox controlled-setting-with-label"> 405 class="checkbox controlled-setting-with-label">
406 <label> 406 <label>
407 <input id="ip-automatic-configuration-checkbox" 407 <input id="ip-automatic-configuration-checkbox"
408 type="checkbox"> 408 type="checkbox">
409 <span> 409 <span>
410 <span i18n-content="ipAutomaticConfiguration"></span> 410 <span i18n-content="ipAutomaticConfiguration"></span>
411 <span class="controlled-setting-indicator" 411 <span class="controlled-setting-indicator"
412 managed="StaticIPConfig.IPAddress"></span> 412 managed="IPConfigType"></span>
pneubeck (no reviews) 2015/01/08 09:47:13 IPAddressConfigType
stevenjb 2015/01/08 17:09:58 Oops, thanks. Done. Also did a grep, no other miss
413 </span> 413 </span>
414 </label> 414 </label>
415 </div> 415 </div>
416 <div> 416 <div>
417 <table id="ip-address-settings"> 417 <table id="ip-address-settings">
418 <tr> 418 <tr>
419 <td class="spacer" width="14px"></td> 419 <td class="spacer" width="14px"></td>
420 <td class="option-name" i18n-content="inetAddress"></td> 420 <td class="option-name" i18n-content="inetAddress"></td>
421 <td><div id="ip-address"></div></td> 421 <td><div id="ip-address"></div></td>
422 </tr> 422 </tr>
(...skipping 24 matching lines...) Expand all
447 <input id="google-dns-radio" type="radio" name="dnstype" 447 <input id="google-dns-radio" type="radio" name="dnstype"
448 value="google"> 448 value="google">
449 <span id="google-dns-label"></span> 449 <span id="google-dns-label"></span>
450 </label> 450 </label>
451 </div> 451 </div>
452 <div id="google-dns-display" class="dns-display"></div> 452 <div id="google-dns-display" class="dns-display"></div>
453 <div class="radio"> 453 <div class="radio">
454 <label> 454 <label>
455 <input id="user-dns-radio" type="radio" name="dnstype" 455 <input id="user-dns-radio" type="radio" name="dnstype"
456 value="user"> 456 value="user">
457 <span i18n-content="userNameServers"></span> 457 <span>
458 <span i18n-content="userNameServers"></span>
459 <span class="controlled-setting-indicator"
460 managed="NameServersConfigType"></span>
461 </span>
458 </label> 462 </label>
459 </div> 463 </div>
460 <table id="user-dns-settings"> 464 <table id="user-dns-settings">
461 <tr> 465 <tr>
462 <td class="spacer" width="14px"></td> 466 <td class="spacer" width="14px"></td>
463 <td> 467 <td>
464 <div id="ipconfig-dns1" i18n-placeholder-text="userNameServer1" 468 <div id="ipconfig-dns1" i18n-placeholder-text="userNameServer1"
465 allow-empty> 469 allow-empty>
466 </div> 470 </div>
467 </td> 471 </td>
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 <button id="details-internet-disconnect" i18n-content="disconnectButton"> 676 <button id="details-internet-disconnect" i18n-content="disconnectButton">
673 </button> 677 </button>
674 <button id="details-internet-configure" i18n-content="configureButton"> 678 <button id="details-internet-configure" i18n-content="configureButton">
675 </button> 679 </button>
676 <button id="activate-details" i18n-content="activateButton"></button> 680 <button id="activate-details" i18n-content="activateButton"></button>
677 <button id="view-account-details" i18n-content="viewAccountButton"> 681 <button id="view-account-details" i18n-content="viewAccountButton">
678 </button> 682 </button>
679 </div> 683 </div>
680 </div> 684 </div>
681 </div> 685 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698