Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/onc/docs/onc_spec.html

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1
Patch Set: Fix mock expectation Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/onc/docs/onc_spec.html
diff --git a/components/onc/docs/onc_spec.html b/components/onc/docs/onc_spec.html
index f4e70c808c956715b81a6564d755b8b156681511..1c26a3578e3a8db01bf2749ce622f8e5cf5e9a99 100644
--- a/components/onc/docs/onc_spec.html
+++ b/components/onc/docs/onc_spec.html
@@ -268,7 +268,8 @@
<span class="type">IPConfig</span>
</span>
Each property set in this IPConfig object overrides the respective
- parameter received over DHCP.
+ parameter received over DHCP. If the IPAddress property of the object is
+ unspecifed or empty, the network will be configured to use DHCP values.
pneubeck (no reviews) 2014/11/25 21:13:34 This reads very very contradicting. The dictionary
stevenjb 2014/11/25 21:59:47 I was trying to keep this reasonably simple, but d
pneubeck (no reviews) 2014/11/27 18:55:01 I started a CL only about the ONC change of IPConf
</dd>
<dt class="field">SavedIPConfig</dt>
@@ -319,8 +320,8 @@
<span class="value">false</span>, otherwise ignored)
<span class="type">array of string</span>
</span>
- Array of addresses to use for name servers. If not specified, DHCP values
- will be used.
+ Array of addresses to use for name servers. If not specified or empty,
+ DHCP values will be used.
</dd>
<dt class="field">SearchDomains</dt>

Powered by Google App Engine
This is Rietveld 408576698