components/onc/docs/onc_spec.html - Issue 708563005: Use setProperties for IP Config.

Side by Side Diff: components/onc/docs/onc_spec.html

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1

Patch Set: Fix mock expectation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="stylesheet" href="onc_spec.css" >	5 <link rel="stylesheet" href="onc_spec.css" >

6 <script src="onc_spec.js"></script>	6 <script src="onc_spec.js"></script>

7 <title>Open Network Configuration Format</title>	7 <title>Open Network Configuration Format</title>

8 </head>	8 </head>

9 <body>	9 <body>

10	10

(...skipping 250 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
261 </dd>	261 </dd>

262	262

263 <dt class="field">StaticIPConfig</dt>	263 <dt class="field">StaticIPConfig</dt>

264 <dd>	264 <dd>

265 <span class="field_meta">	265 <span class="field_meta">

266 (optional if <span class="field">Remove</span> is	266 (optional if <span class="field">Remove</span> is

267 <span class="value">false</span>, otherwise ignored)	267 <span class="value">false</span>, otherwise ignored)

268 <span class="type">IPConfig</span>	268 <span class="type">IPConfig</span>

269 </span>	269 </span>

270 Each property set in this IPConfig object overrides the respective	270 Each property set in this IPConfig object overrides the respective

271 parameter received over DHCP.	271 parameter received over DHCP. If the IPAddress property of the object is

	272 unspecifed or empty, the network will be configured to use DHCP values.
	pneubeck (no reviews) 2014/11/25 21:13:34 This reads very very contradicting. The dictionary This reads very very contradicting. The dictionary name reads 'StaticIPConfig' but it allows for Automatic (DHCP) configuration. The 'IPConfig' type specifies that 'IPAddress' is a required field and that it must be an IP address, i.e. non-empty. But this sentence allows for it to be empty or unset. Everywhere else in this document, if there were multiple alternative configurations with different sets of parameters, a 'type' field was used and depending on the type subdictionaries were required. Analogously, this would mean in this case: "IPConfigType" field of type string, value must be one of {"Automatic", "Static"}, optional, defaults to "Automatic" "StaticIPConfig" field of type IPConfig, required if IPConfigType==Static stevenjb 2014/11/25 21:59:47 I was trying to keep this reasonably simple, but d Show quoted text On 2014/11/25 21:13:34, pneubeck wrote: > This reads very very contradicting. The dictionary name reads 'StaticIPConfig' > but it allows for Automatic (DHCP) configuration. > The 'IPConfig' type specifies that 'IPAddress' is a required field and that it > must be an IP address, i.e. non-empty. But this sentence allows for it to be > empty or unset. > > Everywhere else in this document, if there were multiple alternative > configurations with different sets of parameters, a 'type' field was used and > depending on the type subdictionaries were required. > Analogously, this would mean in this case: > > "IPConfigType" field of type string, value must be one of {"Automatic", > "Static"}, optional, defaults to "Automatic" > > "StaticIPConfig" field of type IPConfig, required if IPConfigType==Static I was trying to keep this reasonably simple, but do want to do this in a way that makes sense to you also. I'm not sure I entirely follow your suggestion. I think it might be easiest if you were to update the spec the way you would like it and email it to me (or whatever), and I will implement it that way? Thanks! pneubeck (no reviews) 2014/11/27 18:55:01 I started a CL only about the ONC change of IPConf Show quoted text On 2014/11/25 21:59:47, stevenjb wrote: > On 2014/11/25 21:13:34, pneubeck wrote: > > This reads very very contradicting. The dictionary name reads 'StaticIPConfig' > > but it allows for Automatic (DHCP) configuration. > > The 'IPConfig' type specifies that 'IPAddress' is a required field and that it > > must be an IP address, i.e. non-empty. But this sentence allows for it to be > > empty or unset. > > > > Everywhere else in this document, if there were multiple alternative > > configurations with different sets of parameters, a 'type' field was used and > > depending on the type subdictionaries were required. > > Analogously, this would mean in this case: > > > > "IPConfigType" field of type string, value must be one of {"Automatic", > > "Static"}, optional, defaults to "Automatic" > > > > "StaticIPConfig" field of type IPConfig, required if IPConfigType==Static > > I was trying to keep this reasonably simple, but do want to do this in a way > that makes sense to you also. I'm not sure I entirely follow your suggestion. I > think it might be easiest if you were to update the spec the way you would like > it and email it to me (or whatever), and I will implement it that way? Thanks! I started a CL only about the ONC change of IPConfig which I can finish tomorrow. Maybe that can save you some work.
272 </dd>	273 </dd>

273	274

274 <dt class="field">SavedIPConfig</dt>	275 <dt class="field">SavedIPConfig</dt>

275 <dd>	276 <dd>

276 <span class="field_meta">	277 <span class="field_meta">

277 (optional for connected networks, read-only)	278 (optional for connected networks, read-only)

278 <span class="type">IPConfig</span>	279 <span class="type">IPConfig</span>

279 </span>	280 </span>

280 IPConfig property containing the configuration that was received from the	281 IPConfig property containing the configuration that was received from the

281 DHCP server prior to applying any StaticIPConfig parameters.	282 DHCP server prior to applying any StaticIPConfig parameters.

(...skipping 23 matching lines...) Expand all Loading...
305 <dt class="field">ProxySettings</dt>	306 <dt class="field">ProxySettings</dt>

306 <dd>	307 <dd>

307 <span class="field_meta">	308 <span class="field_meta">

308 (optional if <span class="field">Remove</span> is	309 (optional if <span class="field">Remove</span> is

309 <span class="value">false</span>, otherwise ignored)	310 <span class="value">false</span>, otherwise ignored)

310 <span class="type">ProxySettings</span>	311 <span class="type">ProxySettings</span>

311 </span>	312 </span>

312 Proxy settings for this network	313 Proxy settings for this network

313 </dd>	314 </dd>

314	315

315 <dt class="field">NameServers</dt>	316 <dt class="field">NameServers</dt>
	pneubeck (no reviews) 2014/11/25 21:13:34 I think you wanted to change the NameServers field I think you wanted to change the NameServers field in IPConfig and not the toplevel one? stevenjb 2014/11/25 21:59:47 Yes, you're right. We'll want to make sure we can Show quoted text On 2014/11/25 21:13:34, pneubeck wrote: > I think you wanted to change the NameServers field in IPConfig and not the > toplevel one? Yes, you're right. We'll want to make sure we can configure NameServers automatically independently of the IPAddress/Gateway/Prefix parameters in the updated spec.
316 <dd>	317 <dd>

317 <span class="field_meta">	318 <span class="field_meta">

318 (optional if <span class="field">Remove</span> is	319 (optional if <span class="field">Remove</span> is

319 <span class="value">false</span>, otherwise ignored)	320 <span class="value">false</span>, otherwise ignored)

320 <span class="type">array of string</span>	321 <span class="type">array of string</span>

321 </span>	322 </span>

322 Array of addresses to use for name servers. If not specified, DHCP values	323 Array of addresses to use for name servers. If not specified or empty,

323 will be used.	324 DHCP values will be used.

324 </dd>	325 </dd>

325	326

326 <dt class="field">SearchDomains</dt>	327 <dt class="field">SearchDomains</dt>

327 <dd>	328 <dd>

328 <span class="field_meta">	329 <span class="field_meta">

329 (optional if <span class="field">Remove</span> is	330 (optional if <span class="field">Remove</span> is

330 <span class="value">false</span>, otherwise ignored)	331 <span class="value">false</span>, otherwise ignored)

331 <span class="type">array of string</span>	332 <span class="type">array of string</span>

332 </span>	333 </span>

333 Array of strings to append to names for resolution. Items in this array	334 Array of strings to append to names for resolution. Items in this array

(...skipping 2664 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2998 is transmitted or saved to disk should be secure. On client device, when	2999 is transmitted or saved to disk should be secure. On client device, when

2999 user names for connections that are user-specific are persisted to disk,	3000 user names for connections that are user-specific are persisted to disk,

3000 they should be stored in a location that is encrypted. Users can also opt in	3001 they should be stored in a location that is encrypted. Users can also opt in

3001 these cases to not save their user credentials in the config file and will	3002 these cases to not save their user credentials in the config file and will

3002 instead be prompted when they are needed.	3003 instead be prompted when they are needed.

3003 </p>	3004 </p>

3004 </section>	3005 </section>

3005 </section>	3006 </section>

3006 </body>	3007 </body>

3007 </html>	3008 </html>

OLD	NEW

« chromeos/network/network_configuration_handler.cc ('K') | « chromeos/test/data/network/shill_ethernet_automatic_ip.json ('k') | no next file » | no next file with comments »